* [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv'
@ 2020-02-11 14:03 YueHaibing
2020-02-11 15:21 ` Jérôme Pouiller
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-02-11 14:03 UTC (permalink / raw)
To: jerome.pouiller, gregkh; +Cc: devel, linux-kernel, YueHaibing
drivers/staging/wfx/queue.c: In function wfx_tx_queues_get:
drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not used [-Wunused-but-set-variable]
commit 2e57865e79cf ("staging: wfx: pspoll_mask make no sense")
left behind this unused variable.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/wfx/queue.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
index 0bcc61f..c73d158 100644
--- a/drivers/staging/wfx/queue.c
+++ b/drivers/staging/wfx/queue.c
@@ -481,7 +481,6 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
struct wfx_queue *vif_queue = NULL;
u32 tx_allowed_mask = 0;
u32 vif_tx_allowed_mask = 0;
- const struct wfx_tx_priv *tx_priv = NULL;
struct wfx_vif *wvif;
int not_found;
int burst;
@@ -541,7 +540,6 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
skb = wfx_tx_queue_get(wdev, queue, tx_allowed_mask);
if (!skb)
continue;
- tx_priv = wfx_skb_tx_priv(skb);
hif = (struct hif_msg *) skb->data;
wvif = wdev_to_wvif(wdev, hif->interface);
WARN_ON(!wvif);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv'
2020-02-11 14:03 [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv' YueHaibing
@ 2020-02-11 15:21 ` Jérôme Pouiller
2020-02-11 15:24 ` Jérôme Pouiller
0 siblings, 1 reply; 3+ messages in thread
From: Jérôme Pouiller @ 2020-02-11 15:21 UTC (permalink / raw)
To: YueHaibing
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On Tuesday 11 February 2020 15:03:34 CET YueHaibing wrote:
> drivers/staging/wfx/queue.c: In function wfx_tx_queues_get:
> drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not used [-Wunused-but-set-variable]
>
> commit 2e57865e79cf ("staging: wfx: pspoll_mask make no sense")
> left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/wfx/queue.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
> index 0bcc61f..c73d158 100644
> --- a/drivers/staging/wfx/queue.c
> +++ b/drivers/staging/wfx/queue.c
> @@ -481,7 +481,6 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
> struct wfx_queue *vif_queue = NULL;
> u32 tx_allowed_mask = 0;
> u32 vif_tx_allowed_mask = 0;
> - const struct wfx_tx_priv *tx_priv = NULL;
> struct wfx_vif *wvif;
> int not_found;
> int burst;
> @@ -541,7 +540,6 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
> skb = wfx_tx_queue_get(wdev, queue, tx_allowed_mask);
> if (!skb)
> continue;
> - tx_priv = wfx_skb_tx_priv(skb);
> hif = (struct hif_msg *) skb->data;
> wvif = wdev_to_wvif(wdev, hif->interface);
> WARN_ON(!wvif);
> --
> 2.7.4
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv'
2020-02-11 15:21 ` Jérôme Pouiller
@ 2020-02-11 15:24 ` Jérôme Pouiller
0 siblings, 0 replies; 3+ messages in thread
From: Jérôme Pouiller @ 2020-02-11 15:24 UTC (permalink / raw)
To: driverdev-devel@linuxdriverproject.org
Cc: YueHaibing, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
On Tuesday 11 February 2020 16:21:41 CET Jérôme Pouiller wrote:
> On Tuesday 11 February 2020 15:03:34 CET YueHaibing wrote:
> > drivers/staging/wfx/queue.c: In function wfx_tx_queues_get:
> > drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not used [-Wunused-but-set-variable]
> >
> > commit 2e57865e79cf ("staging: wfx: pspoll_mask make no sense")
> > left behind this unused variable.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Maybe it could make sens to add a Fixes tag with the commit id that
introduce the warning?
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-11 15:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-11 14:03 [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv' YueHaibing
2020-02-11 15:21 ` Jérôme Pouiller
2020-02-11 15:24 ` Jérôme Pouiller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox