From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
Bo Liu <liubo03@inspur.com>,
xiang@kernel.org
Cc: chao@kernel.org, linux-erofs@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] erofs: Add support for FS_IOC_GETFSLABEL
Date: Tue, 23 Sep 2025 10:59:49 +0800 [thread overview]
Message-ID: <221cc0ee-60a7-4672-987b-cd80a5b13590@kernel.org> (raw)
In-Reply-To: <85be6910-3aa2-4e88-ac16-989fde00c38e@linux.alibaba.com>
On 9/23/25 10:34, Gao Xiang wrote:
> Hi Chao,
>
> On 2025/9/23 10:23, Chao Yu wrote:
>> On 9/22/25 17:29, Bo Liu wrote:
>>> From: Bo Liu (OpenAnolis) <liubo03@inspur.com>
>>>
>>> Add support for reading to the erofs volume label from the
>>> FS_IOC_GETFSLABEL ioctls.
>>>
>>> Signed-off-by: Bo Liu (OpenAnolis) <liubo03@inspur.com>
>>> ---
>
> ...
>
>>> +long erofs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
>>
>> #ifdef CONFIG_COMPAT
>>
>>> +long erofs_compat_ioctl(struct file *filp, unsigned int cmd,
>>> + unsigned long arg);
>
> Since it's a function declaration, when CONFIG_COMPAT is not defined,
> there is no user to use erofs_compat_ioctl(), so I think it is fine
> to just leave the declaration here?
Xiang,
Sure, it won't affect compile and link, we can leave it as it is since it's trivial.
Thanks,
>
> Thanks,
> Gao Xiang
>
>>
>> #endif
>>
>> Thanks,
>>
>>> +
>>
>
>
next prev parent reply other threads:[~2025-09-23 2:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 9:29 [PATCH v4] erofs: Add support for FS_IOC_GETFSLABEL Bo Liu
2025-09-22 9:39 ` Gao Xiang
2025-09-23 2:23 ` Chao Yu
2025-09-23 2:34 ` Gao Xiang
2025-09-23 2:59 ` Chao Yu [this message]
2025-09-23 3:09 ` Gao Xiang
2025-09-23 2:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221cc0ee-60a7-4672-987b-cd80a5b13590@kernel.org \
--to=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).