Re: [PATCH v4] erofs: Add support for FS_IOC_GETFSLABEL

[Gao Xiang <hsiangkao@linux.alibaba.com>]

On 2025/9/23 10:59, Chao Yu wrote:
> On 9/23/25 10:34, Gao Xiang wrote:
>> Hi Chao,
>>
>> On 2025/9/23 10:23, Chao Yu wrote:
>>> On 9/22/25 17:29, Bo Liu wrote:
>>>> From: Bo Liu (OpenAnolis) <liubo03@inspur.com>
>>>>
>>>> Add support for reading to the erofs volume label from the
>>>> FS_IOC_GETFSLABEL ioctls.
>>>>
>>>> Signed-off-by: Bo Liu (OpenAnolis) <liubo03@inspur.com>
>>>> ---
>>
>> ...
>>
>>>>    +long erofs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
>>>
>>> #ifdef CONFIG_COMPAT
>>>
>>>> +long erofs_compat_ioctl(struct file *filp, unsigned int cmd,
>>>> +            unsigned long arg);
>>
>> Since it's a function declaration, when CONFIG_COMPAT is not defined,
>> there is no user to use erofs_compat_ioctl(), so I think it is fine
>> to just leave the declaration here?
> 
> Xiang,
> 
> Sure, it won't affect compile and link, we can leave it as it is since it's trivial.

Yeah, my preference is to avoid unnecessary #ifdef if possible,
anyway (since unused function declarations won't affect anything..)

Thanks,
Gao Xiang

> 
> Thanks,
> 
>>
>> Thanks,
>> Gao Xiang
>>
>>>
>>> #endif
>>>
>>> Thanks,
>>>
>>>> +
>>>
>>
>>