From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Eugene Shalygin <eugene.shalygin@gmail.com>
Cc: andy.shevchenko@gmail.com, pauk.denis@gmail.com,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v5 3/3] hwmon: deprecate asis_wmi_ec_sensors driver
Date: Wed, 12 Jan 2022 22:51:35 +0100 [thread overview]
Message-ID: <2224186.ElGaqSPkdT@natalenko.name> (raw)
In-Reply-To: <20220111180347.1245774-4-eugene.shalygin@gmail.com>
Hello.
On úterý 11. ledna 2022 19:03:46 CET Eugene Shalygin wrote:
> ---
> drivers/hwmon/Kconfig | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 2c16b19d2c03..5e693c93d43a 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -2243,13 +2243,16 @@ config SENSORS_ASUS_WMI
>
> config SENSORS_ASUS_WMI_EC
> tristate "ASUS WMI B550/X570"
> - depends on ACPI_WMI
> + depends on ACPI_WMI && !SENSORS_ASUS_EC
Not sure how it handles `SENSORS_ASUS_EC=m`. Probably, it should be:
```
depends on ACPI_WMI && SENSORS_ASUS_EC=n
```
?
> help
> If you say yes here you get support for the ACPI embedded controller
> hardware monitoring interface found in B550/X570 ASUS motherboards.
> This driver will provide readings of fans, voltages and temperatures
> through the system firmware.
>
> + This driver is deprecated in favor of the ASUS EC Sensors driver
> + which provides fully compatible output.
> +
> This driver can also be built as a module. If so, the module
> will be called asus_wmi_sensors_ec.
Thanks.
--
Oleksandr Natalenko (post-factum)
next prev parent reply other threads:[~2022-01-12 21:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 18:03 PATCH v4 ASUS EC Sensors Eugene Shalygin
2022-01-11 18:03 ` [PATCH v5 1/3] hwmon: (asus-ec-sensors) add driver for ASUS EC Eugene Shalygin
2022-01-11 18:03 ` [PATCH v5 2/3] hwmon: (asus-ec-sensors) update documentation Eugene Shalygin
2022-01-11 18:03 ` [PATCH v5 3/3] hwmon: deprecate asis_wmi_ec_sensors driver Eugene Shalygin
2022-01-12 21:51 ` Oleksandr Natalenko [this message]
2022-01-13 2:51 ` Guenter Roeck
2022-01-15 12:32 ` Oleksandr Natalenko
2022-01-11 18:16 ` PATCH v4 ASUS EC Sensors Barnabás Pőcze
2022-01-11 18:34 ` Eugene Shalygin
2022-01-16 19:28 ` Oleksandr Natalenko
2022-01-16 19:47 ` Eugene Shalygin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2224186.ElGaqSPkdT@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=andy.shevchenko@gmail.com \
--cc=eugene.shalygin@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pauk.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox