Re: PATCH v4 ASUS EC Sensors

[Oleksandr Natalenko <oleksandr@natalenko.name>]

Hello.

On úterý 11. ledna 2022 19:03:43 CET Eugene Shalygin wrote:
> This patchset replaces the HWMON asus_wmi_ec_sensors driver with
> an implementation that does not use WMI but queries the embedded
> controller directly.
> 
> That provides two enhancements: sensor reading became quicker (on some
> systems or kernel configuration it took almost a full second to read
> all the sensors, that transfers less than 15 bytes of data), the driver
> became more fexible. The driver now relies on ACPI mutex to lock access
> to the EC, in the same way as the WMI DSDT code does.
> 
> Chenges in v5:
>  - Place the sensors bitset directly into the driver_data field of the
> 	 dmi_system_id struct.
>  - Replace doc comments with regular ones.

BTW, is this OK:

```
[   11.104396] asus-ec-sensors PNP0C09:00: board has 6 EC sensors that span 7 registers
[   11.104400] asus-ec-sensors PNP0C09:00: hwmon: 'asus-ec-sensors' is not a valid name attribute, please fix
```

?

> 
> Changes in v4:
>  - Deprecate the wmi driver rather than removing it.
> 
> Changes in v3:
>  - Remove BIOS version checks and BIOS version dependent mutex path.
> 
> Changes in v2:
>  - Replace sensor flags enum with bitset
>  - Replace module init/probe functions with module_platform_driver_probe
>    and ask the platform drivers framework to load the driver when ACPI
>    EC is found (ACPI ID "PNP0C09").
>  - Extend board data with BIOS version attribute for the mutex path to be
>    BIOS version dependent.
>  - Add module parameter to override the mutex path.

Thanks.

-- 
Oleksandr Natalenko (post-factum)