* [PATCH] Media: Platform: Omap3isp: Do not forget to call
@ 2016-11-25 4:44 Shailendra Verma
2016-11-25 14:27 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Shailendra Verma @ 2016-11-25 4:44 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Laurent Pinchart, linux-media,
linux-kernel, Shailendra Verma, Shailendra Verma
Cc: vidushi.koul
v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition
before returing from the function.
Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
---
drivers/media/platform/omap3isp/ispvideo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c
index 7354469..2822e2f 100644
--- a/drivers/media/platform/omap3isp/ispvideo.c
+++ b/drivers/media/platform/omap3isp/ispvideo.c
@@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file)
done:
if (ret < 0) {
v4l2_fh_del(&handle->vfh);
+ v4l2_fh_exit(&handle->vfh);
kfree(handle);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Media: Platform: Omap3isp: Do not forget to call
2016-11-25 4:44 [PATCH] Media: Platform: Omap3isp: Do not forget to call Shailendra Verma
@ 2016-11-25 14:27 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2016-11-25 14:27 UTC (permalink / raw)
To: Shailendra Verma
Cc: Mauro Carvalho Chehab, linux-media, linux-kernel,
Shailendra Verma, vidushi.koul
Hi Shailendra,
Thank you for the patch.
On Friday 25 Nov 2016 10:14:32 Shailendra Verma wrote:
> v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition
> before returing from the function.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
> drivers/media/platform/omap3isp/ispvideo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/omap3isp/ispvideo.c
> b/drivers/media/platform/omap3isp/ispvideo.c index 7354469..2822e2f 100644
> --- a/drivers/media/platform/omap3isp/ispvideo.c
> +++ b/drivers/media/platform/omap3isp/ispvideo.c
> @@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file)
> done:
> if (ret < 0) {
> v4l2_fh_del(&handle->vfh);
> + v4l2_fh_exit(&handle->vfh);
While at it you should call v4l2_fh_exit() in the isp_video_release() function
as well. I propose updating the commit message to
v4l: omap3isp: Clean up file handle in open() and release()
Both functions initialize the file handle with v4l2_fh_init() and thus
need to call clean up with v4l2_fh_exit() as appropriate. Fix it.
Same comment for the OMAP4 ISS patches you've submitted.
> kfree(handle);
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-25 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-25 4:44 [PATCH] Media: Platform: Omap3isp: Do not forget to call Shailendra Verma
2016-11-25 14:27 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox