public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/4] Add support Yuridenki-Shokai Kakip board
@ 2025-01-16 14:47 Nobuhiro Iwamatsu
  2025-01-16 14:47 ` [PATCH v2 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants Nobuhiro Iwamatsu
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2025-01-16 14:47 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi,
	Nobuhiro Iwamatsu

Hi all,

This patch series add basic support for Yuridenki-Shokai[0] Kakip board[1] based
on R9A09G057H48.
And this series supports the following:

  - Memory
  - Input clocks
  - Pin Control
  - SCIF
  - OSTM0 - OSTM7
  - SDHI0

v2:
  - Fix the rule of binding for boards.
    kakip board uses r9a09g057h48 only.
  - Drop bootargs from chosen.
  - Fix binding name for regulators.
  - Fix the name style of the regulator.
  - Use DTS coding style.

Best regatrds,
  Nobuhiro

[0]: https://www.yuridenki.co.jp/
[1]: https://www.kakip.ai/

Nobuhiro Iwamatsu (4):
  dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants
  dt-bindings: vendor-prefixes: Add Yuridenki-Shokai Co. Ltd.
  dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board
  arm64: dts: renesas: Add initial device tree for Yuridenki-Shokai
    Kakip board

 .../bindings/soc/renesas/renesas.yaml         |   9 ++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/renesas/Makefile          |   1 +
 .../boot/dts/renesas/r9a09g057h48-kakip.dts   | 136 ++++++++++++++++++
 4 files changed, 148 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts

-- 
2.47.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants
  2025-01-16 14:47 [PATCH v2 0/4] Add support Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
@ 2025-01-16 14:47 ` Nobuhiro Iwamatsu
  2025-01-23 10:57   ` Geert Uytterhoeven
  2025-01-16 14:47 ` [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add Yuridenki-Shokai Co. Ltd Nobuhiro Iwamatsu
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2025-01-16 14:47 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi,
	Nobuhiro Iwamatsu, Krzysztof Kozlowski

Add SoC documentation for Renesas RZ/V2H(P) (r9a09g057h4[568]) SoC.

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---
v2: No update

 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index 225c0f07ae94c8..4f2645e8140c5c 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -552,6 +552,9 @@ properties:
               - renesas,r9a09g057h41 # RZ/V2H
               - renesas,r9a09g057h42 # RZ/V2H with Mali-G31 support
               - renesas,r9a09g057h44 # RZ/V2HP with Mali-G31 + Mali-C55 support
+              - renesas,r9a09g057h45 # RZ/V2H with cryptographic extension support
+              - renesas,r9a09g057h46 # RZ/V2H with Mali-G31 + cryptographic extension support
+              - renesas,r9a09g057h48 # RZ/V2HP with Mali-G31 + Mali-C55 + cryptographic extension support
           - const: renesas,r9a09g057
 
 additionalProperties: true
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add Yuridenki-Shokai Co. Ltd.
  2025-01-16 14:47 [PATCH v2 0/4] Add support Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
  2025-01-16 14:47 ` [PATCH v2 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants Nobuhiro Iwamatsu
@ 2025-01-16 14:47 ` Nobuhiro Iwamatsu
  2025-01-23 10:57   ` Geert Uytterhoeven
  2025-01-16 14:47 ` [PATCH v2 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
  2025-01-16 14:47 ` [PATCH v2 4/4] arm64: dts: renesas: Add initial device tree for " Nobuhiro Iwamatsu
  3 siblings, 1 reply; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2025-01-16 14:47 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi,
	Nobuhiro Iwamatsu, Krzysztof Kozlowski

Add entry for Yuridenki-Shokai Co. Ltd. (https://www.yuridenki.co.jp)

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---
v2: No update.

 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index da01616802c768..5e26fe32a50e7b 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1727,6 +1727,8 @@ patternProperties:
     description: Shenzhen Yashi Changhua Intelligent Technology Co., Ltd.
   "^ysoft,.*":
     description: Y Soft Corporation a.s.
+  "^yuridenki,.*":
+    description: Yuridenki-Shokai Co. Ltd.
   "^zarlink,.*":
     description: Zarlink Semiconductor
   "^zealz,.*":
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board
  2025-01-16 14:47 [PATCH v2 0/4] Add support Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
  2025-01-16 14:47 ` [PATCH v2 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants Nobuhiro Iwamatsu
  2025-01-16 14:47 ` [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add Yuridenki-Shokai Co. Ltd Nobuhiro Iwamatsu
@ 2025-01-16 14:47 ` Nobuhiro Iwamatsu
  2025-01-16 15:14   ` Krzysztof Kozlowski
  2025-01-23 10:58   ` Geert Uytterhoeven
  2025-01-16 14:47 ` [PATCH v2 4/4] arm64: dts: renesas: Add initial device tree for " Nobuhiro Iwamatsu
  3 siblings, 2 replies; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2025-01-16 14:47 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi,
	Nobuhiro Iwamatsu

Add "yuridenki,kakip" which targets the Yuridenki-Shokai Kakip board.

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

---
v2: Fix the rule of binding for boards.
    kakip board uses r9a09g057h48 only.

 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index 4f2645e8140c5c..a8af4fce596127 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -557,6 +557,12 @@ properties:
               - renesas,r9a09g057h48 # RZ/V2HP with Mali-G31 + Mali-C55 + cryptographic extension support
           - const: renesas,r9a09g057
 
+      - description: Yuridenki-Shokai RZ/V2H Kakip
+        items:
+          - const: yuridenki,kakip
+          - const: renesas,r9a09g057h48
+          - const: renesas,r9a09g057
+
 additionalProperties: true
 
 ...
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 4/4] arm64: dts: renesas: Add initial device tree for Yuridenki-Shokai Kakip board
  2025-01-16 14:47 [PATCH v2 0/4] Add support Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
                   ` (2 preceding siblings ...)
  2025-01-16 14:47 ` [PATCH v2 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
@ 2025-01-16 14:47 ` Nobuhiro Iwamatsu
  2025-01-23 10:58   ` Geert Uytterhoeven
  3 siblings, 1 reply; 10+ messages in thread
From: Nobuhiro Iwamatsu @ 2025-01-16 14:47 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi,
	Nobuhiro Iwamatsu

Add basic support for Yuridenki-Shokai Kakip board based on R9A09G057H48.
This commit supports the following:

  - Memory
  - Input clocks
  - Pin Control
  - SCIF
  - OSTM0 - OSTM7
  - SDHI0

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

---
v2: Drop bootargs from chosen.
    Fix binding name for regulators.
    Fix the name style of the regulator.
    Use DTS coding style.

 arch/arm64/boot/dts/renesas/Makefile          |   1 +
 .../boot/dts/renesas/r9a09g057h48-kakip.dts   | 136 ++++++++++++++++++
 2 files changed, 137 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 928635f2e76bbb..698f790bd42524 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -149,6 +149,7 @@ dtb-$(CONFIG_ARCH_R9A09G011) += r9a09g011-v2mevk2.dtb
 dtb-$(CONFIG_ARCH_R9A09G047) += r9a09g047e57-smarc.dtb
 
 dtb-$(CONFIG_ARCH_R9A09G057) += r9a09g057h44-rzv2h-evk.dtb
+dtb-$(CONFIG_ARCH_R9A09G057) += r9a09g057h48-kakip.dtb
 
 dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo
 dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo
diff --git a/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
new file mode 100644
index 00000000000000..b35a6c0499ee7c
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
@@ -0,0 +1,136 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+/*
+ * Device Tree Source for Yuridenki-Shokai the Kakip board
+ *
+ * Copyright (C) 2024 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/pinctrl/renesas,r9a09g057-pinctrl.h>
+#include <dt-bindings/gpio/gpio.h>
+#include "r9a09g057.dtsi"
+
+/ {
+	model = "Yuridenki-Shokai Kakip Board based on r9a09g057h48";
+	compatible = "yuridenki,kakip", "renesas,r9a09g057h48", "renesas,r9a09g057";
+
+	aliases {
+		serial0 = &scif;
+		mmc0 = &sdhi0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@48000000 {
+		device_type = "memory";
+		/* first 128MB is reserved for secure area. */
+		reg = <0x0 0x48000000 0x1 0xF8000000>;
+	};
+
+	reg_3p3v: regulator-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
+	vqmmc_sdhi0: regulator-vccq-sdhi0 {
+		compatible = "regulator-gpio";
+		regulator-name = "SDHI0 VccQ";
+		gpios = <&pinctrl RZV2H_GPIO(A, 0) GPIO_ACTIVE_HIGH>;
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		gpios-states = <0>;
+		states = <3300000 0 1800000 1>;
+	};
+};
+
+&qextal_clk {
+	clock-frequency = <24000000>;
+};
+
+&pinctrl {
+	scif_pins: scif {
+		pins =  "SCIF_RXD", "SCIF_TXD";
+	};
+
+	sd0-pwr-en-hog {
+		gpio-hog;
+		gpios = <RZV2H_GPIO(A, 1) GPIO_ACTIVE_HIGH>;
+		output-high;
+		line-name = "sd0_pwr_en";
+	};
+
+	sdhi0_pins: sd0 {
+		sd0-data {
+			pins = "SD0DAT0", "SD0DAT1", "SD0DAT2", "SD0DAT3", "SD0CMD";
+			input-enable;
+			renesas,output-impedance = <3>;
+			slew-rate = <0>;
+		};
+
+		sd0-clk {
+			pins = "SD0CLK";
+			renesas,output-impedance = <3>;
+			slew-rate = <0>;
+		};
+
+		sd0-mux {
+			pinmux = <RZV2H_PORT_PINMUX(A, 5, 15)>; /* SD0_CD */
+		};
+	};
+};
+
+&scif {
+	pinctrl-0 = <&scif_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&ostm0 {
+	status = "okay";
+};
+
+&ostm1 {
+	status = "okay";
+};
+
+&ostm2 {
+	status = "okay";
+};
+
+&ostm3 {
+	status = "okay";
+};
+
+&ostm4 {
+	status = "okay";
+};
+
+&ostm5 {
+	status = "okay";
+};
+
+&ostm6 {
+	status = "okay";
+};
+
+&ostm7 {
+	status = "okay";
+};
+
+&sdhi0 {
+	pinctrl-0 = <&sdhi0_pins>;
+	pinctrl-names = "default";
+	vmmc-supply = <&reg_3p3v>;
+	vqmmc-supply = <&vqmmc_sdhi0>;
+	bus-width = <4>;
+
+	status = "okay";
+};
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board
  2025-01-16 14:47 ` [PATCH v2 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
@ 2025-01-16 15:14   ` Krzysztof Kozlowski
  2025-01-23 10:58   ` Geert Uytterhoeven
  1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-16 15:14 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi

On 16/01/2025 15:47, Nobuhiro Iwamatsu wrote:
> Add "yuridenki,kakip" which targets the Yuridenki-Shokai Kakip board.
> 
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> 
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants
  2025-01-16 14:47 ` [PATCH v2 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants Nobuhiro Iwamatsu
@ 2025-01-23 10:57   ` Geert Uytterhoeven
  0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2025-01-23 10:57 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu
  Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi,
	Krzysztof Kozlowski

On Thu, Jan 16, 2025 at 3:48 PM Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
> Add SoC documentation for Renesas RZ/V2H(P) (r9a09g057h4[568]) SoC.
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.15.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add Yuridenki-Shokai Co. Ltd.
  2025-01-16 14:47 ` [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add Yuridenki-Shokai Co. Ltd Nobuhiro Iwamatsu
@ 2025-01-23 10:57   ` Geert Uytterhoeven
  0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2025-01-23 10:57 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu
  Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi,
	Krzysztof Kozlowski

On Thu, Jan 16, 2025 at 3:48 PM Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
> Add entry for Yuridenki-Shokai Co. Ltd. (https://www.yuridenki.co.jp)
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.15.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board
  2025-01-16 14:47 ` [PATCH v2 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
  2025-01-16 15:14   ` Krzysztof Kozlowski
@ 2025-01-23 10:58   ` Geert Uytterhoeven
  1 sibling, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2025-01-23 10:58 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu
  Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi

On Thu, Jan 16, 2025 at 3:48 PM Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
> Add "yuridenki,kakip" which targets the Yuridenki-Shokai Kakip board.
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>
> ---
> v2: Fix the rule of binding for boards.
>     kakip board uses r9a09g057h48 only.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.15.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 4/4] arm64: dts: renesas: Add initial device tree for Yuridenki-Shokai Kakip board
  2025-01-16 14:47 ` [PATCH v2 4/4] arm64: dts: renesas: Add initial device tree for " Nobuhiro Iwamatsu
@ 2025-01-23 10:58   ` Geert Uytterhoeven
  0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2025-01-23 10:58 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu
  Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-renesas-soc, devicetree, linux-kernel, Masato Kiuchi

Hi Iwamatsu-san,

On Thu, Jan 16, 2025 at 3:48 PM Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
> Add basic support for Yuridenki-Shokai Kakip board based on R9A09G057H48.
> This commit supports the following:
>
>   - Memory
>   - Input clocks
>   - Pin Control
>   - SCIF
>   - OSTM0 - OSTM7
>   - SDHI0
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>
> ---
> v2: Drop bootargs from chosen.
>     Fix binding name for regulators.
>     Fix the name style of the regulator.
>     Use DTS coding style.

Thanks for the update!

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts

> +/ {

> +       vqmmc_sdhi0: regulator-vccq-sdhi0 {
> +               compatible = "regulator-gpio";
> +               regulator-name = "SDHI0 VccQ";
> +               gpios = <&pinctrl RZV2H_GPIO(A, 0) GPIO_ACTIVE_HIGH>;
> +               regulator-min-microvolt = <1800000>;
> +               regulator-max-microvolt = <3300000>;
> +               gpios-states = <0>;
> +               states = <3300000 0 1800000 1>;

"states = <3300000 0>, <1800000 1>;", as these are two tuples.

> +       };
> +};
> +
> +&qextal_clk {
> +       clock-frequency = <24000000>;
> +};
> +
> +&pinctrl {

Please sort nodes alphabetically.

> +&scif {

> +};
> +
> +&ostm0 {

Likewise.

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.15, with the above fixed.
No need to resend.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-01-23 10:58 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-16 14:47 [PATCH v2 0/4] Add support Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
2025-01-16 14:47 ` [PATCH v2 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants Nobuhiro Iwamatsu
2025-01-23 10:57   ` Geert Uytterhoeven
2025-01-16 14:47 ` [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add Yuridenki-Shokai Co. Ltd Nobuhiro Iwamatsu
2025-01-23 10:57   ` Geert Uytterhoeven
2025-01-16 14:47 ` [PATCH v2 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
2025-01-16 15:14   ` Krzysztof Kozlowski
2025-01-23 10:58   ` Geert Uytterhoeven
2025-01-16 14:47 ` [PATCH v2 4/4] arm64: dts: renesas: Add initial device tree for " Nobuhiro Iwamatsu
2025-01-23 10:58   ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox