From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] mfd: sec-irq: fix support for devices without irq specified
Date: Thu, 07 Aug 2014 18:42:28 +0200 [thread overview]
Message-ID: <22704524.WE4thfvSda@amdc1032> (raw)
Add missing check for the case of device without irq specified
in sec_irq_exit() (please note that sec_irq_init() already
correctly handles such devices).
This is needed for Insignal's Exynos4412 based Origen board.
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
patch is against next-20140804 branch of linux-next kernel
drivers/mfd/sec-irq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c
index f9a5786..b65a7f0 100644
--- a/drivers/mfd/sec-irq.c
+++ b/drivers/mfd/sec-irq.c
@@ -478,5 +478,6 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
void sec_irq_exit(struct sec_pmic_dev *sec_pmic)
{
- regmap_del_irq_chip(sec_pmic->irq, sec_pmic->irq_data);
+ if (sec_pmic->irq)
+ regmap_del_irq_chip(sec_pmic->irq, sec_pmic->irq_data);
}
--
1.8.2.3
next reply other threads:[~2014-08-07 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 16:42 Bartlomiej Zolnierkiewicz [this message]
2014-08-07 16:48 ` [PATCH] mfd: sec-irq: fix support for devices without irq specified Bartlomiej Zolnierkiewicz
2014-08-08 7:34 ` Krzysztof Kozlowski
2014-08-08 7:48 ` Krzysztof Kozlowski
2014-08-08 12:44 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22704524.WE4thfvSda@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox