From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Simon Arlott <simon@fire.lp0.eu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage
Date: Wed, 27 Jan 2016 16:51:11 +0100 [thread overview]
Message-ID: <2271111.AdDD0dnl0s@wuerfel> (raw)
In-Reply-To: <1453908849-25166-1-git-send-email-broonie@kernel.org>
On Wednesday 27 January 2016 15:34:09 Mark Brown wrote:
> ---
> drivers/base/regmap/regmap-mmio.c | 261 ++++++++++++++++++++------------------
> 1 file changed, 140 insertions(+), 121 deletions(-)
Overall looks good to me, but one bug:
> +
> +#ifdef __64BIT
> +static void regmap_mmio_write64le(struct regmap_mmio_context *ctx,
> + unsigned int reg,
> + unsigned int val)
> +{
> + writeq(val, ctx->regs + reg);
> +}
> +#endif
s/__64BIT/CONFIG_64BIT/
here and in one other line.
Arnd
next prev parent reply other threads:[~2016-01-27 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 15:34 [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage Mark Brown
2016-01-27 15:51 ` Arnd Bergmann [this message]
2016-01-27 16:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2271111.AdDD0dnl0s@wuerfel \
--to=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox