From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, linux-wireless@vger.kernel.org,
Ajay Singh <ajay.kathat@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Kalle Valo <kvalo@kernel.org>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: wilc1000: Add error handling for wilc_sdio_cmd52()
Date: Fri, 16 May 2025 15:50:44 +0200 [thread overview]
Message-ID: <22ba7622-a838-47a8-b0f8-29a90d6df34c@web.de> (raw)
In-Reply-To: <20250516083842.903-1-vulab@iscas.ac.cn>
…
> Add error handling for wilc_sdio_cmd52(). If wilc_sdio_cmd52() fails,
> log an error message via dev_err().
Please avoid duplicate exception handling code.
Can another jump target become nicer for this purpose?
Regards,
Markus
next prev parent reply other threads:[~2025-05-16 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 8:38 [PATCH] wifi: wilc1000: Add error handling for wilc_sdio_cmd52() Wentao Liang
2025-05-16 13:50 ` Markus Elfring [this message]
2025-05-16 13:56 ` Johannes Berg
2025-05-17 20:35 ` kernel test robot
2025-05-19 7:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ba7622-a838-47a8-b0f8-29a90d6df34c@web.de \
--to=markus.elfring@web.de \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox