From: Johannes Berg <johannes@sipsolutions.net>
To: Markus Elfring <Markus.Elfring@web.de>,
vulab@iscas.ac.cn, linux-wireless@vger.kernel.org,
Ajay Singh <ajay.kathat@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Kalle Valo <kvalo@kernel.org>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: wilc1000: Add error handling for wilc_sdio_cmd52()
Date: Fri, 16 May 2025 15:56:07 +0200 [thread overview]
Message-ID: <ab918cc3d5e26a6c38b3331172b60b6676bc32c5.camel@sipsolutions.net> (raw)
In-Reply-To: <22ba7622-a838-47a8-b0f8-29a90d6df34c@web.de>
On Fri, 2025-05-16 at 15:50 +0200, Markus Elfring wrote:
> …
> > Add error handling for wilc_sdio_cmd52(). If wilc_sdio_cmd52() fails,
> > log an error message via dev_err().
>
> Please avoid duplicate exception handling code.
> Can another jump target become nicer for this purpose?
>
<form letter>
(stolen from Greg)
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
next prev parent reply other threads:[~2025-05-16 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 8:38 [PATCH] wifi: wilc1000: Add error handling for wilc_sdio_cmd52() Wentao Liang
2025-05-16 13:50 ` Markus Elfring
2025-05-16 13:56 ` Johannes Berg [this message]
2025-05-17 20:35 ` kernel test robot
2025-05-19 7:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab918cc3d5e26a6c38b3331172b60b6676bc32c5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Markus.Elfring@web.de \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox