From: Luiz Capitulino <luizcap@amazon.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: <tj@kernel.org>, <lizefan.x@bytedance.com>, <hannes@cmpxchg.org>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<longman@redhat.com>, <lcapitulino@gmail.com>
Subject: Re: [PATH v2] cgroup: add cgroup_favordynmods= command-line option
Date: Thu, 7 Sep 2023 11:16:41 -0400 [thread overview]
Message-ID: <236f84be-26b0-758d-3d3f-380e536f72c2@amazon.com> (raw)
In-Reply-To: <lqcl5cblo3s45afvtgqjkbz2an3zwccsckglhpe3ufyffqavjk@ui45m6itz4ne>
On 2023-09-07 11:06, Michal Koutný wrote:
> On Wed, Sep 06, 2023 at 12:57:12AM +0000, Luiz Capitulino <luizcap@amazon.com> wrote:
>> We have a need of using favordynmods with cgroup v1, which doesn't support
>> changing mount flags during remount. Enabling CONFIG_FAVOR_DYNMODS at
>> build-time is not an option because we want to be able to selectively
>> enable it for certain systems.
>
> Could this be implemented by a utility that would read /proc/cmdline
> (while kernel ignores the arg) and remount respective hierarchies
> accordingly? Or what do I miss?
Yeah, this works for cgroup v2 but my understanding is that cgroup v1
doesn't support changing flags in remount, take a look at
cgroup1_reconfigure().
- Luiz
next prev parent reply other threads:[~2023-09-07 16:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 0:57 [PATH v2] cgroup: add cgroup_favordynmods= command-line option Luiz Capitulino
2023-09-06 1:53 ` Waiman Long
2023-09-06 6:58 ` Kamalesh Babulal
2023-09-06 12:59 ` Waiman Long
2023-09-07 9:51 ` [External] : " Kamalesh Babulal
2023-09-07 18:47 ` Luiz Capitulino
2023-09-08 7:04 ` Kamalesh Babulal
2023-09-07 15:06 ` Michal Koutný
2023-09-07 15:16 ` Luiz Capitulino [this message]
2023-09-07 15:57 ` Michal Koutný
2023-09-07 18:57 ` Luiz Capitulino
[not found] ` <29bdb453-c6e3-a047-1f27-e9656da92301@amazon.com>
2023-09-18 17:47 ` Tejun Heo
2023-09-19 11:00 ` Michal Koutný
2023-09-19 13:42 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=236f84be-26b0-758d-3d3f-380e536f72c2@amazon.com \
--to=luizcap@amazon.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=lcapitulino@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox