From: Luiz Capitulino <luizcap@amazon.com>
To: "Michal Koutný" <mkoutny@suse.com>, "Tejun Heo" <tj@kernel.org>
Cc: <lizefan.x@bytedance.com>, <hannes@cmpxchg.org>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<longman@redhat.com>, <lcapitulino@gmail.com>
Subject: Re: [PATH v2] cgroup: add cgroup_favordynmods= command-line option
Date: Tue, 19 Sep 2023 09:42:21 -0400 [thread overview]
Message-ID: <55e64e7a-5783-94ce-a9fc-1979587c755f@amazon.com> (raw)
In-Reply-To: <7zv7lqkondaacjhmc7oscyqzwugguxvjw2yhdhkv4axhhkts7a@upoxgl3qpunt>
On 2023-09-19 07:00, Michal Koutný wrote:
> On Mon, Sep 18, 2023 at 07:47:13AM -1000, Tejun Heo <tj@kernel.org> wrote:
>> Michal raised some valid concerns. I don't really mind that it's not great
>> on the edges tho. Michal, what do you think?
>
> I'd have a few suggestions:
> - reset to have_dynmods value instead of false in cgroup_destroy_root()
> (to the benefing of the users of this option, not the common default
> users) or not touch the value in cgroup_destroy_root() at all
> - s/CONFIG_FAVOR_DYNMODS/CONFIG_CGROUP_FAVOR_DYNMODS/ in commit message
Thank you for the detailed suggestions, Michal. I'll on this for v3.
- Luiz
prev parent reply other threads:[~2023-09-19 13:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 0:57 [PATH v2] cgroup: add cgroup_favordynmods= command-line option Luiz Capitulino
2023-09-06 1:53 ` Waiman Long
2023-09-06 6:58 ` Kamalesh Babulal
2023-09-06 12:59 ` Waiman Long
2023-09-07 9:51 ` [External] : " Kamalesh Babulal
2023-09-07 18:47 ` Luiz Capitulino
2023-09-08 7:04 ` Kamalesh Babulal
2023-09-07 15:06 ` Michal Koutný
2023-09-07 15:16 ` Luiz Capitulino
2023-09-07 15:57 ` Michal Koutný
2023-09-07 18:57 ` Luiz Capitulino
[not found] ` <29bdb453-c6e3-a047-1f27-e9656da92301@amazon.com>
2023-09-18 17:47 ` Tejun Heo
2023-09-19 11:00 ` Michal Koutný
2023-09-19 13:42 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55e64e7a-5783-94ce-a9fc-1979587c755f@amazon.com \
--to=luizcap@amazon.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=lcapitulino@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox