From: Krzysztof Kozlowski <krzk@kernel.org>
To: feng.wei8@zte.com.cn, johannes@sipsolutions.net,
xie.ludan@zte.com.cn, shao.mingyin@zte.com.cn,
xie.ludan@zte.com.cn, tang.dongxing@zte.com.cn,
davem@davemloft.net, feng.wei8@zte.com.cn
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()
Date: Mon, 17 Mar 2025 09:27:38 +0100 [thread overview]
Message-ID: <24629d2d-0432-4811-9eee-634e3fe55419@kernel.org> (raw)
In-Reply-To: <20250317125553028rN6mepsLlgyvSWxALaCDB@zte.com.cn>
On 17/03/2025 05:55, feng.wei8@zte.com.cn wrote:
> I see the following commit：
> |https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ab936836ec09fa23954e8e5785d71a41e5ee8bcb
I do not see Johannes merged that. Do you understand how Git and kernel
process work?
>
> I don't think code optimization and unification is "garbage". If so, why did you choose to merge into a commit like "garbage".
> I'm just bothered by this aspect when I usually look at the code, so why not be concise.
No, you just run some static tools, coccinelle or whatever else and
flood us with patches all over the tree, claiming that they improve
anything.
Nothing here was done in terms of choice of improvement but it's pure
automation.
In many places it was already pointed out that your automation is not
even correct.
> I would even like to implement `min4/max4` like `dml_min4/dml_max4`. Wouldn't that be more concise code?
>
> As a newcomer, my perspectives may differ from those of the experts here. I apologize if this has caused any inconvenience.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-17 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 3:12 [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3() feng.wei8
2025-03-16 14:00 ` Johannes Berg
2025-03-17 4:55 ` feng.wei8
2025-03-17 8:27 ` Krzysztof Kozlowski [this message]
2025-03-17 8:30 ` Krzysztof Kozlowski
2025-03-17 8:31 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24629d2d-0432-4811-9eee-634e3fe55419@kernel.org \
--to=krzk@kernel.org \
--cc=davem@davemloft.net \
--cc=feng.wei8@zte.com.cn \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=shao.mingyin@zte.com.cn \
--cc=tang.dongxing@zte.com.cn \
--cc=xie.ludan@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox