From: Johannes Berg <johannes@sipsolutions.net>
To: Krzysztof Kozlowski <krzk@kernel.org>,
feng.wei8@zte.com.cn, linux-kernel@vger.kernel.org,
tang.dongxing@zte.com.cn, shao.mingyin@zte.com.cn,
xie.ludan@zte.com.cn, yang.guang5@zte.com.cn,
yang.yang29@zte.com.cn, ye.xingchen@zte.com.cn,
xu.xin16@zte.com.cn
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()
Date: Mon, 17 Mar 2025 09:31:38 +0100 [thread overview]
Message-ID: <8c02c4f7452f2fbb41c8bc0517af9588c25ca7b1.camel@sipsolutions.net> (raw)
In-Reply-To: <f6dfffc0-a9bd-4a5f-9d83-f3a4b7918010@kernel.org>
On Mon, 2025-03-17 at 09:30 +0100, Krzysztof Kozlowski wrote:
>
> > +++ b/net/mac80211/rc80211_minstrel_ht.c
> > @@ -1010,7 +1010,7 @@ minstrel_ht_refill_sample_rates(struct minstrel_ht_sta *mi)
> > u32 prob_dur = minstrel_get_duration(mi->max_prob_rate);
> > u32 tp_dur = minstrel_get_duration(mi->max_tp_rate[0]);
> > u32 tp2_dur = minstrel_get_duration(mi->max_tp_rate[1]);
> > - u32 fast_rate_dur = min(tp_dur, tp2_dur, prob_dur);
> > + u32 fast_rate_dur = min3(tp_dur, tp2_dur, prob_dur);
>
> This is automation-generated junk code. How does it "simplify the
> statement"?
It's worse. The "minus" code doesn't even exist upstream.
> Can ZTE slow down this flood of automation or research experiment on
> kernel community?
Please.
johannes
prev parent reply other threads:[~2025-03-17 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 3:12 [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3() feng.wei8
2025-03-16 14:00 ` Johannes Berg
2025-03-17 4:55 ` feng.wei8
2025-03-17 8:27 ` Krzysztof Kozlowski
2025-03-17 8:30 ` Krzysztof Kozlowski
2025-03-17 8:31 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c02c4f7452f2fbb41c8bc0517af9588c25ca7b1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=feng.wei8@zte.com.cn \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=shao.mingyin@zte.com.cn \
--cc=tang.dongxing@zte.com.cn \
--cc=xie.ludan@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.guang5@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox