confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

[Alexander Stohr]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1336 bytes --]

a "make bzImage" produces this command:

cmd_arch/i386/kernel/vmlinux.lds.s :=                                       
   
gcc -E -Wp,-MD,arch/i386/kernel/.vmlinux.lds.s.d                            
   
 -nostdinc -iwithprefix include -D__KERNEL__ -Iinclude  -D__ASSEMBLY__      
   
 -Iinclude/asm-i386/mach-default -traditional                               
   
                                                                            
   
    -o arch/i386/kernel/vmlinux.lds.s arch/i386/kernel/vmlinux.lds.S        
   
                                                                            
   
it should produce something like this:

cmd_arch/i386/kernel/vmlinux.lds.s :=                                       
   
gcc -E -Wp,-MD,arch/i386/kernel/.vmlinux.lds.s.d                            
   
 -nostdinc -iwithprefix include -D__KERNEL__ -Iinclude  -D__ASSEMBLY__      
   
 -Iinclude/asm-i386/mach-default -traditional                               
   
 -P -C -Ui386                                                               
   
    -o arch/i386/kernel/vmlinux.lds.s arch/i386/kernel/vmlinux.lds.S

see the last but one line for the difference.

-Alex. (i am not subscribed to this list)

-- 
NEU: WLAN-Router für 0,- EUR* - auch für DSL-Wechsler!
GMX DSL = supergünstig & kabellos http://www.gmx.net/de/go/dsl

Re: confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

[Sam Ravnborg]

On Wed, Aug 04, 2004 at 11:50:03AM +0200, Alexander Stohr wrote:
> a "make bzImage" produces this command:
> 
> cmd_arch/i386/kernel/vmlinux.lds.s :=                                       
>    
> gcc -E -Wp,-MD,arch/i386/kernel/.vmlinux.lds.s.d                            
>    
>  -nostdinc -iwithprefix include -D__KERNEL__ -Iinclude  -D__ASSEMBLY__      
>    
>  -Iinclude/asm-i386/mach-default -traditional                               
>    
>                                                                             
>    
>     -o arch/i386/kernel/vmlinux.lds.s arch/i386/kernel/vmlinux.lds.S        
>    
>                                                                             
>    
> it should produce something like this:
> 
> cmd_arch/i386/kernel/vmlinux.lds.s :=                                       
>    
> gcc -E -Wp,-MD,arch/i386/kernel/.vmlinux.lds.s.d                            
>    
>  -nostdinc -iwithprefix include -D__KERNEL__ -Iinclude  -D__ASSEMBLY__      
>    
>  -Iinclude/asm-i386/mach-default -traditional                               
>    
>  -P -C -Ui386                                                               
>    
>     -o arch/i386/kernel/vmlinux.lds.s arch/i386/kernel/vmlinux.lds.S
> 
> see the last but one line for the difference.

Could you please try to do the following:
1) Add the following lines to bottom of arch/i386/kernel/Makefile
$(warning AFLAGS-lds=$(AFLAGS_vmlinux.lds.o))
$(warning aflags=$(aflags))

2) Delete arch/i386/kernel/vmlinux.lds.s
3) make V=1 arch/i386/kernel/ > mail_to_sam 2>&1

And reply to this mail with output generated.

[Downloading atm. but see no changes that should impose this error].

Also - what shell / system are you using?

	Sam

Re: confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

[Alexander Stohr]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 2457 bytes --]

Sam,

thanks for your qualified hints.
I tried as you did suggest it to me and then it works in the subdir.
Then i retried with "make bzImage" and came to that point in 
compilation for the origin of the failure. (see appended log,
"noise" on language macros an similar stripped...)

As you, and possibly others can see,
the compilation happens from the arch/i386/kernel/timers subdir,
where we got lead to by th arch/i386/kernel subdir directly
and in this case the needed settings seem to lack despite they
were present in a former stage of the compilation.

Having a qualified fix done by a skilled person for that bad behaviour
in any future standard kernel would be nice thing. Thank you so far.

-Alex.
(please CC me in replys, i am not subscribed to this list)


make -f scripts/Makefile.build obj=scripts/basic                            
   
make -f scripts/Makefile.build obj=scripts                                  
   
make -f scripts/Makefile.build obj=scripts/mod                              
   
make -f scripts/Makefile.build obj=arch/i386/kernel
arch/i386/kernel/asm-offsets
.s                                                                          
   
arch/i386/kernel/Makefile:70: AFLAGS-lds=-P -C -Ui386                       
   
arch/i386/kernel/Makefile:71: aflags=
make -f scripts/Makefile.build obj=init
make -f scripts/Makefile.build obj=usr
make -f scripts/Makefile.build obj=arch/i386/kernel                         
   
arch/i386/kernel/Makefile:70: AFLAGS-lds=                                   
   
arch/i386/kernel/Makefile:71: aflags=                                       
   
make -f scripts/Makefile.build obj=arch/i386/kernel/acpi                    
   
make -f scripts/Makefile.build obj=arch/i386/kernel/cpu                     
   
make -f scripts/Makefile.build obj=arch/i386/kernel/cpu/mcheck              
   
make -f scripts/Makefile.build obj=arch/i386/kernel/cpu/mtrr                
   
make -f scripts/Makefile.build obj=arch/i386/kernel/timers                  
   
  gcc -E -Wp,-MD,arch/i386/kernel/.vmlinux.lds.s.d -nostdinc -iwithprefix
includ
e -D__KERNEL__ -Iinclude  -D__ASSEMBLY__ -Iinclude/asm-i386/mach-default
-tradit
ional     -o arch/i386/kernel/vmlinux.lds.s arch/i386/kernel/vmlinux.lds.S
[...]

until it fails for the linking when using the generated lds.s file.

-- 
NEU: WLAN-Router für 0,- EUR* - auch für DSL-Wechsler!
GMX DSL = supergünstig & kabellos http://www.gmx.net/de/go/dsl

Re: confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

[Sam Ravnborg]

On Thu, Aug 05, 2004 at 04:17:56PM +0200, Alexander Stohr wrote:
> 
> As you, and possibly others can see,
> the compilation happens from the arch/i386/kernel/timers subdir,
> where we got lead to by th arch/i386/kernel subdir directly
> and in this case the needed settings seem to lack despite they
> were present in a former stage of the compilation.

What happens is that the value assigned to AFLAGS_vmlinux.lds.o is lost
between the first and the second invocation of make in arch/i386/kernel

The only difference is the setting of LANG etc. - which you deleted
from the log.

Pleae try to delete the following lines from the top-level Makefile and try again:

line 622-626:
	$(Q)if [ ! -z $$LC_ALL ]; then          \
	export LANG=$$LC_ALL;           \
	export LC_ALL= ;                \
	fi;                                     \
	export LC_COLLATE=C; export LC_CTYPE=C; \
	
If this cures the problem then please provide me with you LANG settings.
Both LANG and LC_* variables.

If it still fails please provide me with the _full_ unedited log up until
the point where it fails.

Since I have to reports on this issue I really would like to have it
nailed before 2.6.8 is out.

The other report is from: Pawe? Sikora <pluto@pld-linux.org>

	Sam

Re: confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

[Paweł Sikora]

On Thursday 05 of August 2004 22:33, Sam Ravnborg wrote:
> On Thu, Aug 05, 2004 at 04:17:56PM +0200, Alexander Stohr wrote:
> > As you, and possibly others can see,
> > the compilation happens from the arch/i386/kernel/timers subdir,
> > where we got lead to by th arch/i386/kernel subdir directly
> > and in this case the needed settings seem to lack despite they
> > were present in a former stage of the compilation.
>
> What happens is that the value assigned to AFLAGS_vmlinux.lds.o is lost
> between the first and the second invocation of make in arch/i386/kernel
>
> The only difference is the setting of LANG etc. - which you deleted
> from the log.
>
> Pleae try to delete the following lines from the top-level Makefile and try
> again:
>
> line 622-626:
> 	$(Q)if [ ! -z $$LC_ALL ]; then          \
> 	export LANG=$$LC_ALL;           \
> 	export LC_ALL= ;                \
> 	fi;                                     \
> 	export LC_COLLATE=C; export LC_CTYPE=C; \

-	$(Q)if [ ! -z $$LC_ALL ]; then          \
-		export LANG=$$LC_ALL;           \
-		export LC_ALL= ;                \
-	fi;                                     \
-	export LC_COLLATE=C; export LC_CTYPE=C; \
+	$(Q) \

^^^ works for me.

> If this cures the problem then please provide me with you LANG settings.
> Both LANG and LC_* variables.

only LANG=pl_PL

-- 
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)

Re: confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

[Sam Ravnborg]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

On Sat, Aug 07, 2004 at 06:21:07PM +0200, Pawe? Sikora wrote:
> -	$(Q)if [ ! -z $$LC_ALL ]; then          \
> -		export LANG=$$LC_ALL;           \
> -		export LC_ALL= ;                \
> -	fi;                                     \
> -	export LC_COLLATE=C; export LC_CTYPE=C; \
> +	$(Q) \
> 
> ^^^ works for me.
Thanks!

I need to track this a bit more.
Could you please provide me with information of what
you are running.

make version (make --version)
shell & version of shell
distribution

Could you also try if the attached two Makefiles exhibit the same problem.
Just copy them to an empty directory and execute make.

A good run looks like:
Makefile2:1: lds=-P
Hi

A bad run does not have any -P after the '='.

Needless to say my make does not exhibit this issue.

	Sam

[-- Attachment #2: Makefile --]
[-- Type: text/plain, Size: 275 bytes --]

Q=@
all:
	$(Q)if [ ! -z $$LC_ALL ]; then          \
		export LANG=$$LC_ALL;           \
		export LC_ALL= ;                \
	fi;                                     \
	export LC_COLLATE=C; export LC_CTYPE=C; \
	$(MAKE) -f Makefile2 obj=xxx

export CFLAGS_vmlinux.lds.o := -P

[-- Attachment #3: Makefile2 --]
[-- Type: text/plain, Size: 55 bytes --]

$(warning lds=$(CFLAGS_vmlinux.lds.o))

all:
	@echo Hi

Re: confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

[Paweł Sikora]

On Saturday 07 of August 2004 19:39, Sam Ravnborg wrote:
> On Sat, Aug 07, 2004 at 06:21:07PM +0200, Pawe? Sikora wrote:
> > -	$(Q)if [ ! -z $$LC_ALL ]; then          \
> > -		export LANG=$$LC_ALL;           \
> > -		export LC_ALL= ;                \
> > -	fi;                                     \
> > -	export LC_COLLATE=C; export LC_CTYPE=C; \
> > +	$(Q) \
> >
> > ^^^ works for me.
>
> Thanks!
>
> I need to track this a bit more.
> Could you please provide me with information of what
> you are running.
>
> make version (make --version)
> shell & version of shell
> distribution

make-3.80-5
bash-2.05b-14
PLD(nptl/cvs)

> Could you also try if the attached two Makefiles exhibit the same problem.
> Just copy them to an empty directory and execute make.
>
> A good run looks like:
> Makefile2:1: lds=-P
> Hi

# LANG=pl_PL make
make[1]: Wej?cie do katalogu `/home/users/pluto/rpm/BUILD'
            ^
            ^ error. `ś' is correct char.

Makefile2:1: lds=
Hi
make[1]: Opuszczenie katalogu `/home/users/pluto/rpm/BUILD'

# LANG=C make
make[1]: Entering directory `/home/users/pluto/rpm/BUILD'
Makefile2:1: lds=
Hi
make[1]: Leaving directory `/home/users/pluto/rpm/BUILD'

with a minor fix...

-       export LC_COLLATE=C; export LC_CTYPE=C; \
-       $(MAKE) -f Makefile2 obj=xxx
+       export LC_COLLATE=C; export LC_CTYPE=C;
+       $(Q)$(MAKE) -f Makefile2 obj=xxx

works fine...

# LANG=pl_PL make
make[1]: Wejście do katalogu `/home/users/pluto/rpm/BUILD'
Makefile2:1: lds=-P
Hi
make[1]: Opuszczenie katalogu `/home/users/pluto/rpm/BUILD'

-- 
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)

Re: confirmed: kernel build for 2.6.8-rc3 is broken for at least i386

[Alexander Stohr]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1280 bytes --]

hello Sam,

i think i reached the root cause of my problem:

bash# export AFLAGS_vmlinux.lds.o=123
export: AFLAGS_vmlinux.lds.o=123: not a legal variable name

the problem seems to be raised by dots beeing part of the variable name.

my version of bash is reported like shown here in the environment:
BASH_VERSION=1.14.5(1)

unfortunately the whole build process, including GNU Make 3.80,
fails absolutely silently for this specific point of system error.

sorry that i am feeling unable right now to provide a fix.
maybe some more research is needed to find a viable solution.
in worst case the whole makefile system has to be patched
for any such variable construct. 

on the other side it does look like the normal recursive call sheme
of make is immune to such bash habits, is it? (supposed it launches
itselves directyl and not embedded in a few other shell commands...)

i am not totally sure about that all - especially because i tried
a newer shell which exposed the very same limitation, but there must
be something in that area because i could fiddle out that the var
setting gets lost all the time when calling "scripts/Makefile.build".

-Alex.

-- 
NEU: WLAN-Router für 0,- EUR* - auch für DSL-Wechsler!
GMX DSL = supergünstig & kabellos http://www.gmx.net/de/go/dsl