Re: [PATCH 2/2] devfreq: exynos4: Support initialization of freq_table and max_state of devfreq's profile.

Re: [PATCH 2/2] devfreq: exynos4: Support initialization of freq_table and max_state of devfreq's profile.

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 2189 bytes --]

> This patch initializes freq_table and max_state of devfreq's profile.
> They will be used for creating transition table.
> 
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

> ---
>  drivers/devfreq/exynos4_bus.c |   30 +++++++++++++++++++++++++++++-
>  1 files changed, 29 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> index 88ddc77..9c08855 100644
> --- a/drivers/devfreq/exynos4_bus.c
> +++ b/drivers/devfreq/exynos4_bus.c
> @@ -985,7 +985,8 @@ static __devinit int exynos4_busfreq_probe(struct platform_device *pdev)
>  	struct busfreq_data *data;
>  	struct opp *opp;
>  	struct device *dev = &pdev->dev;
> -	int err = 0;
> +	int err = 0, i;
> +	unsigned int *freq_table;
>  
>  	data = kzalloc(sizeof(struct busfreq_data), GFP_KERNEL);
>  	if (data == NULL) {
> @@ -1042,6 +1043,33 @@ static __devinit int exynos4_busfreq_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, data);
>  
> +	switch (data->type) {
> +	case TYPE_BUSF_EXYNOS4210:
> +		freq_table = devm_kzalloc(&pdev->dev, sizeof(unsigned int) * EX4210_LV_NUM,
> +					GFP_KERNEL);
> +
> +		for (i = 0; i < EX4210_LV_NUM; i++)
> +			freq_table[i] = exynos4210_busclk_table[i].clk;
> +
> +		exynos4_devfreq_profile.max_state = EX4210_LV_NUM;
> +		break;
> +	case TYPE_BUSF_EXYNOS4x12:
> +		freq_table = devm_kzalloc(&pdev->dev, sizeof(unsigned int) * EX4x12_LV_NUM,
> +					GFP_KERNEL);
> +
> +		for (i = 0; i < EX4x12_LV_NUM; i++)
> +			freq_table[i] = exynos4x12_mifclk_table[i].clk;
> +
> +		exynos4_devfreq_profile.max_state = EX4x12_LV_NUM;
> +		break;
> +	default:
> +		dev_err(dev, "Cannot determine the device id %d\n", data->type);
> +		err = -EINVAL;
> +		goto err_opp_add;
> +	}
> +
> +	exynos4_devfreq_profile.freq_table = freq_table;
> +
>  	busfreq_mon_reset(data);
>  
>  	data->devfreq = devfreq_add_device(dev, &exynos4_devfreq_profile,
> -- 
> 1.7.4.1
> 
> 
> 
> 
>        
>   
>          
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

[PATCH 0/2] devfreq: Add sysfs node for representing frequency transition information.

[Jonghwa Lee]

This patchset adds sysfs node to devfreq's frame work to measure trasition of frequency on runtime.
It will be created under '/sys/class/devfreq/<device name>/' as the name of 'trans_state'.
It contains transition table which represents total number of transition of each frerquency state to
others and also time spent the state.

--- example for device having 3 frequency levels ----------------------------------------------------
			 <freq level #1>        <freq level #2>       <freq level #3>	   time_spent
* <freq level #1>		              # of freq1 to freq2    # of freq1 to freq3       t1
  <freq level #2>       # of freq2 to freq1			     # of freq2 to freq3       t2
  <freq level #3>       # of freq3 to freq1   # of freq3 to freq2			       t3
 total transition : N
-----------------------------------------------------------------------------------------------------
('*' represents last frequency changed at the time you inspect the node.)

Patch 1: Make sysfs node to DEVFREQ frame work.
Patch 2: Initialize freq_table and max_state in exynos4 devfreq driver to be
	 used for frequency trnasition measurement.

Jonghwa Lee (2):
  devfreq: Add sysfs node for representing frequency transition
    information.
  devfreq: exynos4: Support initialization of freq_table and max_state
    of devfreq's profile.

 drivers/devfreq/devfreq.c     |   89 +++++++++++++++++++++++++++++++++++++++++
 drivers/devfreq/exynos4_bus.c |   30 +++++++++++++-
 include/linux/devfreq.h       |    9 ++++
 3 files changed, 127 insertions(+), 1 deletions(-)

-- 
1.7.4.1

[PATCH 2/2] devfreq: exynos4: Support initialization of freq_table and max_state of devfreq's profile.

[Jonghwa Lee]

This patch initializes freq_table and max_state of devfreq's profile.
They will be used for creating transition table.

Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
---
 drivers/devfreq/exynos4_bus.c |   30 +++++++++++++++++++++++++++++-
 1 files changed, 29 insertions(+), 1 deletions(-)

diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
index 88ddc77..9c08855 100644
--- a/drivers/devfreq/exynos4_bus.c
+++ b/drivers/devfreq/exynos4_bus.c
@@ -985,7 +985,8 @@ static __devinit int exynos4_busfreq_probe(struct platform_device *pdev)
 	struct busfreq_data *data;
 	struct opp *opp;
 	struct device *dev = &pdev->dev;
-	int err = 0;
+	int err = 0, i;
+	unsigned int *freq_table;
 
 	data = kzalloc(sizeof(struct busfreq_data), GFP_KERNEL);
 	if (data == NULL) {
@@ -1042,6 +1043,33 @@ static __devinit int exynos4_busfreq_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, data);
 
+	switch (data->type) {
+	case TYPE_BUSF_EXYNOS4210:
+		freq_table = devm_kzalloc(&pdev->dev, sizeof(unsigned int) * EX4210_LV_NUM,
+					GFP_KERNEL);
+
+		for (i = 0; i < EX4210_LV_NUM; i++)
+			freq_table[i] = exynos4210_busclk_table[i].clk;
+
+		exynos4_devfreq_profile.max_state = EX4210_LV_NUM;
+		break;
+	case TYPE_BUSF_EXYNOS4x12:
+		freq_table = devm_kzalloc(&pdev->dev, sizeof(unsigned int) * EX4x12_LV_NUM,
+					GFP_KERNEL);
+
+		for (i = 0; i < EX4x12_LV_NUM; i++)
+			freq_table[i] = exynos4x12_mifclk_table[i].clk;
+
+		exynos4_devfreq_profile.max_state = EX4x12_LV_NUM;
+		break;
+	default:
+		dev_err(dev, "Cannot determine the device id %d\n", data->type);
+		err = -EINVAL;
+		goto err_opp_add;
+	}
+
+	exynos4_devfreq_profile.freq_table = freq_table;
+
 	busfreq_mon_reset(data);
 
 	data->devfreq = devfreq_add_device(dev, &exynos4_devfreq_profile,
-- 
1.7.4.1

Re: [PATCH 2/2] devfreq: exynos4: Support initialization of freq_table and max_state of devfreq's profile.

[Rafael J. Wysocki]

On Thursday, August 16, 2012, Jonghwa Lee wrote:
> This patch initializes freq_table and max_state of devfreq's profile.
> They will be used for creating transition table.
> 
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>

Does that depend on [1/2]?

Rafael


> ---
>  drivers/devfreq/exynos4_bus.c |   30 +++++++++++++++++++++++++++++-
>  1 files changed, 29 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> index 88ddc77..9c08855 100644
> --- a/drivers/devfreq/exynos4_bus.c
> +++ b/drivers/devfreq/exynos4_bus.c
> @@ -985,7 +985,8 @@ static __devinit int exynos4_busfreq_probe(struct platform_device *pdev)
>  	struct busfreq_data *data;
>  	struct opp *opp;
>  	struct device *dev = &pdev->dev;
> -	int err = 0;
> +	int err = 0, i;
> +	unsigned int *freq_table;
>  
>  	data = kzalloc(sizeof(struct busfreq_data), GFP_KERNEL);
>  	if (data == NULL) {
> @@ -1042,6 +1043,33 @@ static __devinit int exynos4_busfreq_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, data);
>  
> +	switch (data->type) {
> +	case TYPE_BUSF_EXYNOS4210:
> +		freq_table = devm_kzalloc(&pdev->dev, sizeof(unsigned int) * EX4210_LV_NUM,
> +					GFP_KERNEL);
> +
> +		for (i = 0; i < EX4210_LV_NUM; i++)
> +			freq_table[i] = exynos4210_busclk_table[i].clk;
> +
> +		exynos4_devfreq_profile.max_state = EX4210_LV_NUM;
> +		break;
> +	case TYPE_BUSF_EXYNOS4x12:
> +		freq_table = devm_kzalloc(&pdev->dev, sizeof(unsigned int) * EX4x12_LV_NUM,
> +					GFP_KERNEL);
> +
> +		for (i = 0; i < EX4x12_LV_NUM; i++)
> +			freq_table[i] = exynos4x12_mifclk_table[i].clk;
> +
> +		exynos4_devfreq_profile.max_state = EX4x12_LV_NUM;
> +		break;
> +	default:
> +		dev_err(dev, "Cannot determine the device id %d\n", data->type);
> +		err = -EINVAL;
> +		goto err_opp_add;
> +	}
> +
> +	exynos4_devfreq_profile.freq_table = freq_table;
> +
>  	busfreq_mon_reset(data);
>  
>  	data->devfreq = devfreq_add_device(dev, &exynos4_devfreq_profile,
> 

Re: [PATCH 2/2] devfreq: exynos4: Support initialization of freq_table and max_state of devfreq's profile.

[jonghwa3.lee]

On 2012년 08월 24일 07:22, Rafael J. Wysocki wrote:
> On Thursday, August 16, 2012, Jonghwa Lee wrote:
>> This patch initializes freq_table and max_state of devfreq's profile.
>> They will be used for creating transition table.
>>
>> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
> Does that depend on [1/2]?
>
> Rafael

Not exactly, but it shows that required procedure for using function
included in patch[1/2].


Thanks.

>
>> ---
>>  drivers/devfreq/exynos4_bus.c |   30 +++++++++++++++++++++++++++++-
>>  1 files changed, 29 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
>> index 88ddc77..9c08855 100644
>> --- a/drivers/devfreq/exynos4_bus.c
>> +++ b/drivers/devfreq/exynos4_bus.c
>> @@ -985,7 +985,8 @@ static __devinit int exynos4_busfreq_probe(struct platform_device *pdev)
>>  	struct busfreq_data *data;
>>  	struct opp *opp;
>>  	struct device *dev = &pdev->dev;
>> -	int err = 0;
>> +	int err = 0, i;
>> +	unsigned int *freq_table;
>>  
>>  	data = kzalloc(sizeof(struct busfreq_data), GFP_KERNEL);
>>  	if (data == NULL) {
>> @@ -1042,6 +1043,33 @@ static __devinit int exynos4_busfreq_probe(struct platform_device *pdev)
>>  
>>  	platform_set_drvdata(pdev, data);
>>  
>> +	switch (data->type) {
>> +	case TYPE_BUSF_EXYNOS4210:
>> +		freq_table = devm_kzalloc(&pdev->dev, sizeof(unsigned int) * EX4210_LV_NUM,
>> +					GFP_KERNEL);
>> +
>> +		for (i = 0; i < EX4210_LV_NUM; i++)
>> +			freq_table[i] = exynos4210_busclk_table[i].clk;
>> +
>> +		exynos4_devfreq_profile.max_state = EX4210_LV_NUM;
>> +		break;
>> +	case TYPE_BUSF_EXYNOS4x12:
>> +		freq_table = devm_kzalloc(&pdev->dev, sizeof(unsigned int) * EX4x12_LV_NUM,
>> +					GFP_KERNEL);
>> +
>> +		for (i = 0; i < EX4x12_LV_NUM; i++)
>> +			freq_table[i] = exynos4x12_mifclk_table[i].clk;
>> +
>> +		exynos4_devfreq_profile.max_state = EX4x12_LV_NUM;
>> +		break;
>> +	default:
>> +		dev_err(dev, "Cannot determine the device id %d\n", data->type);
>> +		err = -EINVAL;
>> +		goto err_opp_add;
>> +	}
>> +
>> +	exynos4_devfreq_profile.freq_table = freq_table;
>> +
>>  	busfreq_mon_reset(data);
>>  
>>  	data->devfreq = devfreq_add_device(dev, &exynos4_devfreq_profile,
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>