* [PATCH] irqchip/sun6i-r: Use NULL for chip_data
@ 2022-04-24 17:39 Samuel Holland
2022-04-24 19:50 ` Jernej Škrabec
2022-05-04 16:15 ` [irqchip: irq/irqchip-next] " irqchip-bot for Samuel Holland
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Holland @ 2022-04-24 17:39 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier
Cc: Samuel Holland, kernel test robot, Chen-Yu Tsai, Jernej Skrabec,
linux-arm-kernel, linux-kernel, linux-sunxi
sparse complains about using an integer as a NULL pointer.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/irqchip/irq-sun6i-r.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
index 4cd3e533740b..a01e44049415 100644
--- a/drivers/irqchip/irq-sun6i-r.c
+++ b/drivers/irqchip/irq-sun6i-r.c
@@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain *domain,
for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
if (hwirq == nmi_hwirq) {
irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
- &sun6i_r_intc_nmi_chip, 0);
+ &sun6i_r_intc_nmi_chip,
+ NULL);
irq_set_handler(virq, handle_fasteoi_ack_irq);
} else {
irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
- &sun6i_r_intc_wakeup_chip, 0);
+ &sun6i_r_intc_wakeup_chip,
+ NULL);
}
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/sun6i-r: Use NULL for chip_data
2022-04-24 17:39 [PATCH] irqchip/sun6i-r: Use NULL for chip_data Samuel Holland
@ 2022-04-24 19:50 ` Jernej Škrabec
2022-05-04 16:15 ` [irqchip: irq/irqchip-next] " irqchip-bot for Samuel Holland
1 sibling, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2022-04-24 19:50 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Samuel Holland
Cc: Samuel Holland, kernel test robot, Chen-Yu Tsai, linux-arm-kernel,
linux-kernel, linux-sunxi
Dne nedelja, 24. april 2022 ob 19:39:51 CEST je Samuel Holland napisal(a):
> sparse complains about using an integer as a NULL pointer.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
>
> drivers/irqchip/irq-sun6i-r.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
> index 4cd3e533740b..a01e44049415 100644
> --- a/drivers/irqchip/irq-sun6i-r.c
> +++ b/drivers/irqchip/irq-sun6i-r.c
> @@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain
*domain,
> for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
> if (hwirq == nmi_hwirq) {
> irq_domain_set_hwirq_and_chip(domain, virq,
hwirq,
> -
&sun6i_r_intc_nmi_chip, 0);
> +
&sun6i_r_intc_nmi_chip,
> + NULL);
> irq_set_handler(virq,
handle_fasteoi_ack_irq);
> } else {
> irq_domain_set_hwirq_and_chip(domain, virq,
hwirq,
> -
&sun6i_r_intc_wakeup_chip, 0);
> +
&sun6i_r_intc_wakeup_chip,
> + NULL);
> }
> }
>
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/sun6i-r: Use NULL for chip_data
2022-04-24 17:39 [PATCH] irqchip/sun6i-r: Use NULL for chip_data Samuel Holland
2022-04-24 19:50 ` Jernej Škrabec
@ 2022-05-04 16:15 ` irqchip-bot for Samuel Holland
1 sibling, 0 replies; 3+ messages in thread
From: irqchip-bot for Samuel Holland @ 2022-05-04 16:15 UTC (permalink / raw)
To: linux-kernel
Cc: kernel test robot, Samuel Holland, Jernej Skrabec, Marc Zyngier,
tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 1b2eb89ccf4ffff2ea83c41451b3fed709cd3fc8
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/1b2eb89ccf4ffff2ea83c41451b3fed709cd3fc8
Author: Samuel Holland <samuel@sholland.org>
AuthorDate: Sun, 24 Apr 2022 12:39:51 -05:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Wed, 04 May 2022 16:36:59 +01:00
irqchip/sun6i-r: Use NULL for chip_data
sparse complains about using an integer as a NULL pointer.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220424173952.36591-1-samuel@sholland.org
---
drivers/irqchip/irq-sun6i-r.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
index 4cd3e53..a01e440 100644
--- a/drivers/irqchip/irq-sun6i-r.c
+++ b/drivers/irqchip/irq-sun6i-r.c
@@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain *domain,
for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
if (hwirq == nmi_hwirq) {
irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
- &sun6i_r_intc_nmi_chip, 0);
+ &sun6i_r_intc_nmi_chip,
+ NULL);
irq_set_handler(virq, handle_fasteoi_ack_irq);
} else {
irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
- &sun6i_r_intc_wakeup_chip, 0);
+ &sun6i_r_intc_wakeup_chip,
+ NULL);
}
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-04 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-24 17:39 [PATCH] irqchip/sun6i-r: Use NULL for chip_data Samuel Holland
2022-04-24 19:50 ` Jernej Škrabec
2022-05-04 16:15 ` [irqchip: irq/irqchip-next] " irqchip-bot for Samuel Holland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox