* Re: [PATCH] clk: rockchip: rk3288: fix softreset register count
2014-09-12 9:24 [PATCH] clk: rockchip: rk3288: fix softreset register count Mark yao
@ 2014-09-12 9:56 ` Heiko Stübner
2014-09-25 15:11 ` Doug Anderson
2014-09-25 21:46 ` Mike Turquette
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2014-09-12 9:56 UTC (permalink / raw)
To: Mark yao
Cc: Mike Turquette, linux-kernel, djkurtz, dianders, dkl, eddie.cai,
xjq, kfx, huangtao, zyw, yxj, cym, zhengsq, caesar.wang,
kever.yang
Hi Mark,
Am Freitag, 12. September 2014, 17:24:46 schrieb Mark yao:
> The rk3288 actually has 12 softresets, so fix the register count.
interesting ... I can see the additional registers in the updated TRM, while
the old one didn't have them.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> Signed-off-by: Mark yao <mark.yao@rock-chips.com>
> ---
> drivers/clk/rockchip/clk-rk3288.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3288.c
> b/drivers/clk/rockchip/clk-rk3288.c index 0d8c6c5..2e1d790 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -711,7 +711,7 @@ static void __init rk3288_clk_init(struct device_node
> *np) rockchip_clk_register_branches(rk3288_clk_branches,
> ARRAY_SIZE(rk3288_clk_branches));
>
> - rockchip_register_softrst(np, 9, reg_base + RK3288_SOFTRST_CON(0),
> + rockchip_register_softrst(np, 12, reg_base + RK3288_SOFTRST_CON(0),
> ROCKCHIP_SOFTRST_HIWORD_MASK);
> }
> CLK_OF_DECLARE(rk3288_cru, "rockchip,rk3288-cru", rk3288_clk_init);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: rockchip: rk3288: fix softreset register count
2014-09-12 9:24 [PATCH] clk: rockchip: rk3288: fix softreset register count Mark yao
2014-09-12 9:56 ` Heiko Stübner
@ 2014-09-25 15:11 ` Doug Anderson
2014-09-25 21:46 ` Mike Turquette
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2014-09-25 15:11 UTC (permalink / raw)
To: Mark yao, Mike Turquette
Cc: Heiko Stübner, linux-kernel@vger.kernel.org, Daniel Kurtz,
戴克霖 (Jack), Eddie Cai, Jianqun Xu,
柯飞雄, Tao Huang, Chris,
闫孝军, jeff chen, Shunqian Zheng,
晓腾王, Kever Yang
Hi,
On Fri, Sep 12, 2014 at 2:24 AM, Mark yao <mark.yao@rock-chips.com> wrote:
> The rk3288 actually has 12 softresets, so fix the register count.
>
> Signed-off-by: Mark yao <mark.yao@rock-chips.com>
> ---
> drivers/clk/rockchip/clk-rk3288.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: rockchip: rk3288: fix softreset register count
2014-09-12 9:24 [PATCH] clk: rockchip: rk3288: fix softreset register count Mark yao
2014-09-12 9:56 ` Heiko Stübner
2014-09-25 15:11 ` Doug Anderson
@ 2014-09-25 21:46 ` Mike Turquette
2 siblings, 0 replies; 4+ messages in thread
From: Mike Turquette @ 2014-09-25 21:46 UTC (permalink / raw)
To: Mark yao, heiko
Cc: linux-kernel, djkurtz, dianders, dkl, eddie.cai, xjq, kfx,
huangtao, zyw, yxj, cym, zhengsq, caesar.wang, kever.yang,
Mark yao
Quoting Mark yao (2014-09-12 02:24:46)
> The rk3288 actually has 12 softresets, so fix the register count.
>
> Signed-off-by: Mark yao <mark.yao@rock-chips.com>
Applied to clk-next.
Regards,
Mike
> ---
> drivers/clk/rockchip/clk-rk3288.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> index 0d8c6c5..2e1d790 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -711,7 +711,7 @@ static void __init rk3288_clk_init(struct device_node *np)
> rockchip_clk_register_branches(rk3288_clk_branches,
> ARRAY_SIZE(rk3288_clk_branches));
>
> - rockchip_register_softrst(np, 9, reg_base + RK3288_SOFTRST_CON(0),
> + rockchip_register_softrst(np, 12, reg_base + RK3288_SOFTRST_CON(0),
> ROCKCHIP_SOFTRST_HIWORD_MASK);
> }
> CLK_OF_DECLARE(rk3288_cru, "rockchip,rk3288-cru", rk3288_clk_init);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread