From: Krzysztof Kozlowski <krzk@kernel.org>
To: Haylen Chu <heylenay@4d2.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jisheng Zhang <jszhang@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v5 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal
Date: Wed, 16 Oct 2024 14:03:54 +0200 [thread overview]
Message-ID: <26514aa5-c835-41d4-b0bc-862f3181cb8c@kernel.org> (raw)
In-Reply-To: <Zw-pJZ0jhxR8Oggk@ketchup>
On 16/10/2024 13:53, Haylen Chu wrote:
>>>>> +
>>>>> +properties:
>>>>> + compatible:
>>>>> + enum:
>>>>> + - sophgo,cv1800-thermal
>>>>
>>>> Not much improved, judging by other patches there is no "CV1800" SoC,
>>>> but that's a family name. Otherwise please point us to bindings or DTS
>>>> using this SoC.
>>>
>>> "cv1800" is referenced in the clock binding[1] and usb binding[2]. I
>>> don't think there are other CV1800 SoC variants. Usage of "CV1800"
>>
>> There are. git grep cv1800
>>
>>> should be specific and unambiguous.
>>
>> And other places have different name.
>
> Okay, will use cv1800b in the next revision instead. Thanks.
Just to clarify: I assume the name of the SoC is cv1800b.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-16 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 7:38 [PATCH v5 0/3] riscv: sophgo: add thermal sensor support for cv180x/sg200x SoCs Haylen Chu
2024-10-14 7:38 ` [PATCH v5 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal Haylen Chu
2024-10-15 5:52 ` Krzysztof Kozlowski
2024-10-15 13:07 ` Haylen Chu
2024-10-15 13:34 ` Krzysztof Kozlowski
2024-10-16 11:53 ` Haylen Chu
2024-10-16 12:03 ` Krzysztof Kozlowski [this message]
2024-10-15 5:55 ` Krzysztof Kozlowski
2024-10-15 13:20 ` Haylen Chu
2024-10-14 7:38 ` [PATCH v5 2/3] thermal: cv1800: Add cv1800 thermal driver support Haylen Chu
2024-10-14 7:38 ` [PATCH v5 3/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone Haylen Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26514aa5-c835-41d4-b0bc-862f3181cb8c@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heylenay@4d2.org \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lukasz.luba@arm.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox