* [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"
@ 2023-02-03 8:13 Yu Kuai
2023-02-03 7:59 ` Oleksandr Natalenko
0 siblings, 1 reply; 3+ messages in thread
From: Yu Kuai @ 2023-02-03 8:13 UTC (permalink / raw)
To: tj, oleksandr, axboe
Cc: linux-block, linux-kernel, yukuai3, yukuai1, yi.zhang, yangerkun
From: Yu Kuai <yukuai3@huawei.com>
This reverts commit ec645dc96699ea6c37b6de86c84d7288ea9a4ddf.
This can save some memory, because after commit 0f7839955114 ("Revert
"block/mq-deadline: Add cgroup support""), there are total 5 policies.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
include/linux/blkdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 41a41561b773..c6861c7fdad9 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -54,7 +54,7 @@ extern struct class block_class;
* Maximum number of blkcg policies allowed to be registered concurrently.
* Defined here to simplify include dependency.
*/
-#define BLKCG_MAX_POLS 6
+#define BLKCG_MAX_POLS 5
#define DISK_MAX_PARTS 256
#define DISK_NAME_LEN 32
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"
2023-02-03 8:13 [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS" Yu Kuai
@ 2023-02-03 7:59 ` Oleksandr Natalenko
2023-02-03 8:13 ` Yu Kuai
0 siblings, 1 reply; 3+ messages in thread
From: Oleksandr Natalenko @ 2023-02-03 7:59 UTC (permalink / raw)
To: tj, axboe, Yu Kuai
Cc: linux-block, linux-kernel, yukuai3, yukuai1, yi.zhang, yangerkun
Hello.
On pátek 3. února 2023 9:13:57 CET Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> This reverts commit ec645dc96699ea6c37b6de86c84d7288ea9a4ddf.
>
> This can save some memory, because after commit 0f7839955114 ("Revert
> "block/mq-deadline: Add cgroup support""), there are total 5 policies.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> include/linux/blkdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 41a41561b773..c6861c7fdad9 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -54,7 +54,7 @@ extern struct class block_class;
> * Maximum number of blkcg policies allowed to be registered concurrently.
> * Defined here to simplify include dependency.
> */
> -#define BLKCG_MAX_POLS 6
> +#define BLKCG_MAX_POLS 5
>
> #define DISK_MAX_PARTS 256
> #define DISK_NAME_LEN 32
Last time I asked about reverting this change, it was suggested that we may keep it [1].
[1] https://lore.kernel.org/linux-block/1dc051a8-4d59-8137-2406-f74026b170bd@kernel.dk/
--
Oleksandr Natalenko (post-factum)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"
2023-02-03 7:59 ` Oleksandr Natalenko
@ 2023-02-03 8:13 ` Yu Kuai
0 siblings, 0 replies; 3+ messages in thread
From: Yu Kuai @ 2023-02-03 8:13 UTC (permalink / raw)
To: Oleksandr Natalenko, tj, axboe, Yu Kuai
Cc: linux-block, linux-kernel, yi.zhang, yangerkun, yukuai (C)
Hi,
在 2023/02/03 15:59, Oleksandr Natalenko 写道:
> Hello.
>
> On pátek 3. února 2023 9:13:57 CET Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> This reverts commit ec645dc96699ea6c37b6de86c84d7288ea9a4ddf.
>>
>> This can save some memory, because after commit 0f7839955114 ("Revert
>> "block/mq-deadline: Add cgroup support""), there are total 5 policies.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>> include/linux/blkdev.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>> index 41a41561b773..c6861c7fdad9 100644
>> --- a/include/linux/blkdev.h
>> +++ b/include/linux/blkdev.h
>> @@ -54,7 +54,7 @@ extern struct class block_class;
>> * Maximum number of blkcg policies allowed to be registered concurrently.
>> * Defined here to simplify include dependency.
>> */
>> -#define BLKCG_MAX_POLS 6
>> +#define BLKCG_MAX_POLS 5
>>
>> #define DISK_MAX_PARTS 256
>> #define DISK_NAME_LEN 32
>
> Last time I asked about reverting this change, it was suggested that we may keep it [1].
>
> [1] https://lore.kernel.org/linux-block/1dc051a8-4d59-8137-2406-f74026b170bd@kernel.dk/
>
I see now, thanks for the reply.
Kuai
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-03 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-03 8:13 [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS" Yu Kuai
2023-02-03 7:59 ` Oleksandr Natalenko
2023-02-03 8:13 ` Yu Kuai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox