From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jiri Kosina <trivial@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Prabhakar <prabhakar.csengg@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer()
Date: Wed, 25 Nov 2020 11:48:42 +0300 [thread overview]
Message-ID: <26fc2f22-eae4-86bc-1c39-e8498b77e1cd@gmail.com> (raw)
In-Reply-To: <20201124112552.26377-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hello!
On 24.11.2020 14:25, Lad Prabhakar wrote:
> In the error path of rpcif_manual_xfer() the value of ret is overwritten
> by value returned by reset_control_reset() function and thus returning
> incorrect value to the caller.
>
> This patch makes sure the correct value is returned to the caller of
> rpcif_manual_xfer() by dropping the overwrite of ret in error path.
> Also now we ignore the value returned by reset_control_reset() in the
> error path and instead print a error message when it fails.
>
> Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver")
> Reported-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
MBR, Sergei
next prev parent reply other threads:[~2020-11-25 8:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 11:25 [PATCH 0/5] memory: renesas-rpc-if: Trivial fixes Lad Prabhakar
2020-11-24 11:25 ` [PATCH 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer() Lad Prabhakar
2020-11-25 8:48 ` Sergei Shtylyov [this message]
2020-11-24 11:25 ` [PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline Lad Prabhakar
2020-11-24 15:42 ` Geert Uytterhoeven
2020-11-25 15:32 ` Lad, Prabhakar
2020-11-24 18:11 ` Sergei Shtylyov
2020-11-24 11:25 ` [PATCH 3/5] memory: renesas-rpc-if: Export symbols as GPL Lad Prabhakar
2020-11-25 8:58 ` Sergei Shtylyov
2020-11-24 11:25 ` [PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style comments Lad Prabhakar
2020-11-24 20:04 ` Sergei Shtylyov
2020-11-24 11:25 ` [PATCH 5/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() Lad Prabhakar
2020-11-25 12:10 ` Sergei Shtylyov
2020-11-24 11:34 ` [PATCH 0/5] memory: renesas-rpc-if: Trivial fixes Lad, Prabhakar
2020-11-24 18:25 ` Sergei Shtylyov
2020-11-25 13:31 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26fc2f22-eae4-86bc-1c39-e8498b77e1cd@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stable@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox