From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jiri Kosina <trivial@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style comments
Date: Tue, 24 Nov 2020 23:04:05 +0300 [thread overview]
Message-ID: <8ddf57ec-c1af-cc20-ecba-c8cd96e56d7a@gmail.com> (raw)
In-Reply-To: <20201124112552.26377-5-prabhakar.mahadev-lad.rj@bp.renesas.com>
On 11/24/20 2:25 PM, Lad Prabhakar wrote:
> Replace C++ style comment with C style.
Thanks, I've overlooked this, and the header files should use C style comment,
not C++.
> While at it also replace the tab with a space between struct and
> struct name.
No connection between these 2 changes, so there should be 2 patches, not 1.
Also, I'd like to ask you that they're left intact (unless it causes problems
for you).
> Suggested-by: Pavel Machek <pavel@denx.de>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
[...]
> diff --git a/include/memory/renesas-rpc-if.h b/include/memory/renesas-rpc-if.h
> index b8c7cc63065f..30ea6bd969b4 100644
> --- a/include/memory/renesas-rpc-if.h
> +++ b/include/memory/renesas-rpc-if.h
> @@ -19,7 +19,7 @@ enum rpcif_data_dir {
> RPCIF_DATA_OUT,
> };
>
> -struct rpcif_op {
> +struct rpcif_op {
> struct {
> u8 buswidth;
> u8 opcode;
> @@ -57,7 +57,7 @@ struct rpcif_op {
> } data;
> };
>
> -struct rpcif {
> +struct rpcif {
> struct device *dev;
> void __iomem *dirmap;
> struct regmap *regmap;
> @@ -93,4 +93,4 @@ static inline void rpcif_disable_rpm(struct rpcif *rpc)
> pm_runtime_put_sync(rpc->dev);
> }
>
> -#endif // __RENESAS_RPC_IF_H
> +#endif /* __RENESAS_RPC_IF_H */
MBR, Sergei
next prev parent reply other threads:[~2020-11-24 20:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 11:25 [PATCH 0/5] memory: renesas-rpc-if: Trivial fixes Lad Prabhakar
2020-11-24 11:25 ` [PATCH 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer() Lad Prabhakar
2020-11-25 8:48 ` Sergei Shtylyov
2020-11-24 11:25 ` [PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline Lad Prabhakar
2020-11-24 15:42 ` Geert Uytterhoeven
2020-11-25 15:32 ` Lad, Prabhakar
2020-11-24 18:11 ` Sergei Shtylyov
2020-11-24 11:25 ` [PATCH 3/5] memory: renesas-rpc-if: Export symbols as GPL Lad Prabhakar
2020-11-25 8:58 ` Sergei Shtylyov
2020-11-24 11:25 ` [PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style comments Lad Prabhakar
2020-11-24 20:04 ` Sergei Shtylyov [this message]
2020-11-24 11:25 ` [PATCH 5/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() Lad Prabhakar
2020-11-25 12:10 ` Sergei Shtylyov
2020-11-24 11:34 ` [PATCH 0/5] memory: renesas-rpc-if: Trivial fixes Lad, Prabhakar
2020-11-24 18:25 ` Sergei Shtylyov
2020-11-25 13:31 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ddf57ec-c1af-cc20-ecba-c8cd96e56d7a@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox