From: David Howells <dhowells@redhat.com>
To: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: dhowells@redhat.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace: Fix some checker warnings
Date: Mon, 05 Dec 2022 08:28:35 +0000 [thread overview]
Message-ID: <276025.1670228915@warthog.procyon.org.uk> (raw)
In-Reply-To: <20221205123200.51539846cb9dd9dc158cc871@kernel.org>
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > +#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
> > static const struct file_operations tracing_max_lat_fops;
> > +#endif
>
> Oops, I missed this part. Why did you introduced this #ifdefs?
Because:
#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
static const struct file_operations tracing_max_lat_fops = {
in the same file. You get something like an unused symbol warning otherwise
if neither config option is defined.
David
next prev parent reply other threads:[~2022-12-05 8:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 20:07 [PATCH] trace: Fix some checker warnings David Howells
2022-12-02 12:43 ` kernel test robot
2022-12-05 2:22 ` Masami Hiramatsu
2022-12-05 2:39 ` Steven Rostedt
2022-12-05 3:11 ` Masami Hiramatsu
2022-12-05 3:29 ` Steven Rostedt
2022-12-05 3:29 ` Masami Hiramatsu
2022-12-05 3:33 ` Steven Rostedt
2022-12-02 14:24 ` kernel test robot
2022-12-05 3:32 ` Masami Hiramatsu
2022-12-05 8:28 ` David Howells [this message]
2022-12-05 9:06 ` Masami Hiramatsu
2022-12-05 10:22 ` David Howells
2022-12-05 10:29 ` David Howells
2022-12-06 13:59 ` Masami Hiramatsu
2022-12-05 14:40 ` [PATCH] tracing: Fix complicated dependency of kernel test robot
2022-12-05 15:10 ` kernel test robot
2022-12-06 12:56 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=276025.1670228915@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox