From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
David Howells <dhowells@redhat.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace: Fix some checker warnings
Date: Sun, 4 Dec 2022 22:29:21 -0500 [thread overview]
Message-ID: <20221204222921.047fcf4b@rorschach.local.home> (raw)
In-Reply-To: <20221205121119.537fa922bbd8147b9df5ae6c@kernel.org>
On Mon, 5 Dec 2022 12:11:19 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > #if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \
> > || defined(CONFIG_OSNOISE_TRACER)) && defined(CONFIG_FSNOTIFY)
> > #define LATENCY_FS_NOTIFY
> > +#define USES_MAX_TRACE
> > #endif
> >
> > And use that instead.
>
> BTW, why can't HWLAT_TRACER and OSNOISE_TRACER depend on TRACER_MAX_TRACE?
> I think it is better to reduce combinations of those, especially partially
> enabling a feature seems a bit dangerous.
Well, the issue with that is that if the TRACER_MAX_TRACE is off
(because it's not something commonly selected), it will hide osnoise
and hwlat from showing up in the menus.
-- Steve
next prev parent reply other threads:[~2022-12-05 3:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 20:07 [PATCH] trace: Fix some checker warnings David Howells
2022-12-02 12:43 ` kernel test robot
2022-12-05 2:22 ` Masami Hiramatsu
2022-12-05 2:39 ` Steven Rostedt
2022-12-05 3:11 ` Masami Hiramatsu
2022-12-05 3:29 ` Steven Rostedt [this message]
2022-12-05 3:29 ` Masami Hiramatsu
2022-12-05 3:33 ` Steven Rostedt
2022-12-02 14:24 ` kernel test robot
2022-12-05 3:32 ` Masami Hiramatsu
2022-12-05 8:28 ` David Howells
2022-12-05 9:06 ` Masami Hiramatsu
2022-12-05 10:22 ` David Howells
2022-12-05 10:29 ` David Howells
2022-12-06 13:59 ` Masami Hiramatsu
2022-12-05 14:40 ` [PATCH] tracing: Fix complicated dependency of kernel test robot
2022-12-05 15:10 ` kernel test robot
2022-12-06 12:56 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221204222921.047fcf4b@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mhiramat@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox