* [PATCH] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT
@ 2025-08-27 22:51 Daniel Tang
2025-08-28 5:12 ` Mika Westerberg
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Tang @ 2025-08-27 22:51 UTC (permalink / raw)
To: linux-acpi, linux-kernel, Rafael J. Wysocki, Mika Westerberg
Previously, after `rmmod acpi_tad`, `modprobe acpi_tad` would fail
with this dmesg:
sysfs: cannot create duplicate filename '/devices/platform/ACPI000E:00/time'
Call Trace:
<TASK>
dump_stack_lvl+0x6c/0x90
dump_stack+0x10/0x20
sysfs_warn_dup+0x8b/0xa0
sysfs_add_file_mode_ns+0x122/0x130
internal_create_group+0x1dd/0x4c0
sysfs_create_group+0x13/0x20
acpi_tad_probe+0x147/0x1f0 [acpi_tad]
platform_probe+0x42/0xb0
</TASK>
acpi-tad ACPI000E:00: probe with driver acpi-tad failed with error -17
Fixes: 3230b2b3c1ab5a0d3f99d5850bfdc4bf48d11cdd ("ACPI: TAD: Add low-level support for real time capability")
Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com>
---
drivers/acpi/acpi_tad.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/acpi_tad.c b/drivers/acpi/acpi_tad.c
index 91d7d90c47da..33418dd6768a 100644
--- a/drivers/acpi/acpi_tad.c
+++ b/drivers/acpi/acpi_tad.c
@@ -565,6 +565,9 @@ static void acpi_tad_remove(struct platform_device *pdev)
pm_runtime_get_sync(dev);
+ if (dd->capabilities & ACPI_TAD_RT)
+ sysfs_remove_group(&dev->kobj, &acpi_tad_time_attr_group);
+
if (dd->capabilities & ACPI_TAD_DC_WAKE)
sysfs_remove_group(&dev->kobj, &acpi_tad_dc_attr_group);
--
2.48.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT
2025-08-27 22:51 [PATCH] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT Daniel Tang
@ 2025-08-28 5:12 ` Mika Westerberg
2025-08-28 5:38 ` [PATCH v2] " Daniel Tang
0 siblings, 1 reply; 5+ messages in thread
From: Mika Westerberg @ 2025-08-28 5:12 UTC (permalink / raw)
To: Daniel Tang; +Cc: linux-acpi, linux-kernel, Rafael J. Wysocki
On Wed, Aug 27, 2025 at 06:51:41PM -0400, Daniel Tang wrote:
> Previously, after `rmmod acpi_tad`, `modprobe acpi_tad` would fail
> with this dmesg:
>
> sysfs: cannot create duplicate filename '/devices/platform/ACPI000E:00/time'
> Call Trace:
> <TASK>
> dump_stack_lvl+0x6c/0x90
> dump_stack+0x10/0x20
> sysfs_warn_dup+0x8b/0xa0
> sysfs_add_file_mode_ns+0x122/0x130
> internal_create_group+0x1dd/0x4c0
> sysfs_create_group+0x13/0x20
> acpi_tad_probe+0x147/0x1f0 [acpi_tad]
> platform_probe+0x42/0xb0
> </TASK>
> acpi-tad ACPI000E:00: probe with driver acpi-tad failed with error -17
>
> Fixes: 3230b2b3c1ab5a0d3f99d5850bfdc4bf48d11cdd ("ACPI: TAD: Add low-level support for real time capability")
You should shorten this hash to 12 or so chars. Otherwise looks good.
> Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com>
> ---
> drivers/acpi/acpi_tad.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/acpi_tad.c b/drivers/acpi/acpi_tad.c
> index 91d7d90c47da..33418dd6768a 100644
> --- a/drivers/acpi/acpi_tad.c
> +++ b/drivers/acpi/acpi_tad.c
> @@ -565,6 +565,9 @@ static void acpi_tad_remove(struct platform_device *pdev)
>
> pm_runtime_get_sync(dev);
>
> + if (dd->capabilities & ACPI_TAD_RT)
> + sysfs_remove_group(&dev->kobj, &acpi_tad_time_attr_group);
> +
> if (dd->capabilities & ACPI_TAD_DC_WAKE)
> sysfs_remove_group(&dev->kobj, &acpi_tad_dc_attr_group);
>
> --
> 2.48.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT
2025-08-28 5:12 ` Mika Westerberg
@ 2025-08-28 5:38 ` Daniel Tang
2025-08-28 8:13 ` Mika Westerberg
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Tang @ 2025-08-28 5:38 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-acpi, linux-kernel, Rafael J. Wysocki
Previously, after `rmmod acpi_tad`, `modprobe acpi_tad` would fail
with this dmesg:
sysfs: cannot create duplicate filename '/devices/platform/ACPI000E:00/time'
Call Trace:
<TASK>
dump_stack_lvl+0x6c/0x90
dump_stack+0x10/0x20
sysfs_warn_dup+0x8b/0xa0
sysfs_add_file_mode_ns+0x122/0x130
internal_create_group+0x1dd/0x4c0
sysfs_create_group+0x13/0x20
acpi_tad_probe+0x147/0x1f0 [acpi_tad]
platform_probe+0x42/0xb0
</TASK>
acpi-tad ACPI000E:00: probe with driver acpi-tad failed with error -17
Fixes: 3230b2b3c1ab ("ACPI: TAD: Add low-level support for real time capability")
Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com>
---
drivers/acpi/acpi_tad.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/acpi_tad.c b/drivers/acpi/acpi_tad.c
index 91d7d90c47da..33418dd6768a 100644
--- a/drivers/acpi/acpi_tad.c
+++ b/drivers/acpi/acpi_tad.c
@@ -565,6 +565,9 @@ static void acpi_tad_remove(struct platform_device *pdev)
pm_runtime_get_sync(dev);
+ if (dd->capabilities & ACPI_TAD_RT)
+ sysfs_remove_group(&dev->kobj, &acpi_tad_time_attr_group);
+
if (dd->capabilities & ACPI_TAD_DC_WAKE)
sysfs_remove_group(&dev->kobj, &acpi_tad_dc_attr_group);
--
2.48.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT
2025-08-28 5:38 ` [PATCH v2] " Daniel Tang
@ 2025-08-28 8:13 ` Mika Westerberg
2025-09-04 18:20 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Mika Westerberg @ 2025-08-28 8:13 UTC (permalink / raw)
To: Daniel Tang; +Cc: linux-acpi, linux-kernel, Rafael J. Wysocki
On Thu, Aug 28, 2025 at 01:38:14AM -0400, Daniel Tang wrote:
> Previously, after `rmmod acpi_tad`, `modprobe acpi_tad` would fail
> with this dmesg:
>
> sysfs: cannot create duplicate filename '/devices/platform/ACPI000E:00/time'
> Call Trace:
> <TASK>
> dump_stack_lvl+0x6c/0x90
> dump_stack+0x10/0x20
> sysfs_warn_dup+0x8b/0xa0
> sysfs_add_file_mode_ns+0x122/0x130
> internal_create_group+0x1dd/0x4c0
> sysfs_create_group+0x13/0x20
> acpi_tad_probe+0x147/0x1f0 [acpi_tad]
> platform_probe+0x42/0xb0
> </TASK>
> acpi-tad ACPI000E:00: probe with driver acpi-tad failed with error -17
>
> Fixes: 3230b2b3c1ab ("ACPI: TAD: Add low-level support for real time capability")
> Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT
2025-08-28 8:13 ` Mika Westerberg
@ 2025-09-04 18:20 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2025-09-04 18:20 UTC (permalink / raw)
To: Mika Westerberg, Daniel Tang; +Cc: linux-acpi, linux-kernel, Rafael J. Wysocki
On Thu, Aug 28, 2025 at 10:13 AM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Thu, Aug 28, 2025 at 01:38:14AM -0400, Daniel Tang wrote:
> > Previously, after `rmmod acpi_tad`, `modprobe acpi_tad` would fail
> > with this dmesg:
> >
> > sysfs: cannot create duplicate filename '/devices/platform/ACPI000E:00/time'
> > Call Trace:
> > <TASK>
> > dump_stack_lvl+0x6c/0x90
> > dump_stack+0x10/0x20
> > sysfs_warn_dup+0x8b/0xa0
> > sysfs_add_file_mode_ns+0x122/0x130
> > internal_create_group+0x1dd/0x4c0
> > sysfs_create_group+0x13/0x20
> > acpi_tad_probe+0x147/0x1f0 [acpi_tad]
> > platform_probe+0x42/0xb0
> > </TASK>
> > acpi-tad ACPI000E:00: probe with driver acpi-tad failed with error -17
> >
> > Fixes: 3230b2b3c1ab ("ACPI: TAD: Add low-level support for real time capability")
> > Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied as 6.18 material, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-09-04 18:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 22:51 [PATCH] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT Daniel Tang
2025-08-28 5:12 ` Mika Westerberg
2025-08-28 5:38 ` [PATCH v2] " Daniel Tang
2025-08-28 8:13 ` Mika Westerberg
2025-09-04 18:20 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox