The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	Brian Mayer <bleemayer@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
Date: Fri, 03 Jul 2026 18:12:47 +0200	[thread overview]
Message-ID: <2960762.AiC22s8V5E@diego> (raw)
In-Reply-To: <CAB3eKoDcp=rVGDpvAHEeVLG3rHFw2E1XXxCe2QaApX0aLkyXyA@mail.gmail.com>

Hi Brian,

Am Donnerstag, 2. Juli 2026, 21:09:20 Mitteleuropäische Sommerzeit schrieb Brian Mayer:
> Hi kernel team.
> 
> I was testing building the kernel for my radxa cm5+io shield, and it turns
> out there is no rtc in the DTS, so I got it from the radxa files.
> This is my first email to you, please help me correct it if something is
> off the standards.
> 
> The commit attached does the trick. I used AI to assist me in this in
> case you're
> wondering.

Generally, please don't post patches as attachments.
For review comments it es expected to be able to comment
inline in the patch.
Ideally use git-send-email or b4 for sending patches.

For AI assisted changes, there is an Assisted-by: tag [0]

Please drop the Tested-by tag ... as you're sending in the patch and
your signed-off-by is on it, it is expected that you tested that change :-) .


Patch contents:
Please use names found in the schematics ... the pin is named
 rtc_int_l there ... so the pinctrl entry should be "rtc_int_l: rtc-int-l { "...

This allows easier lookups when going from DT to schematics and back.


Thanks
Heiko


[0] https://docs.kernel.org/process/coding-assistants.html



      reply	other threads:[~2026-07-03 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 19:09 [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board Brian Mayer
2026-07-03 16:12 ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2960762.AiC22s8V5E@diego \
    --to=heiko@sntech.de \
    --cc=bleemayer@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox