* [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
@ 2026-07-02 19:09 Brian Mayer
2026-07-03 16:12 ` Heiko Stübner
0 siblings, 1 reply; 2+ messages in thread
From: Brian Mayer @ 2026-07-02 19:09 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, heiko
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
Hi kernel team.
I was testing building the kernel for my radxa cm5+io shield, and it turns
out there is no rtc in the DTS, so I got it from the radxa files.
This is my first email to you, please help me correct it if something is
off the standards.
The commit attached does the trick. I used AI to assist me in this in
case you're
wondering.
Best, Brian
[-- Attachment #2: 0001-arm64-dts-rockchip-add-HYM8563-RTC-to-Radxa-CM5-IO-b.patch --]
[-- Type: application/octet-stream, Size: 1999 bytes --]
From 8841981021b5f98522ad44fe40e11d0c0e756534 Mon Sep 17 00:00:00 2001
From: Brian Mayer <bleemayer@gmail.com>
Date: Thu, 2 Jul 2026 14:51:51 -0300
Subject: [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
battery holder. Without a device tree node, no /dev/rtc* appears even
when CONFIG_RTC_DRV_HYM8563 is enabled.
Describe the RTC, wire the interrupt pin with a pull-up, mark it as a
wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use
the external clock. Wiring matches Radxa's downstream board support.
Signed-off-by: Brian Mayer <bleemayer@gmail.com>
Tested-by: Brian Mayer <bleemayer@gmail.com>
---
.../dts/rockchip/rk3588s-radxa-cm5-io.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
index af4a9bc01..1a2c72831 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
@@ -19,6 +19,7 @@ / {
aliases {
ethernet0 = &gmac1;
mmc1 = &sdmmc;
+ rtc0 = &hym8563;
};
chosen {
@@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint {
};
};
};
+
+ hym8563: rtc@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ clock-output-names = "hym8563";
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&rtc_int>;
+ wakeup-source;
+ };
};
&i2s5_8ch {
@@ -221,6 +234,12 @@ usbc0_int: usbc0-int {
};
};
+ hym8563 {
+ rtc_int: rtc-int {
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
hdmi {
hdmi0_tx_on_h: hdmi0-tx-on-h {
rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
2026-07-02 19:09 [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board Brian Mayer
@ 2026-07-03 16:12 ` Heiko Stübner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2026-07-03 16:12 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Brian Mayer
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Hi Brian,
Am Donnerstag, 2. Juli 2026, 21:09:20 Mitteleuropäische Sommerzeit schrieb Brian Mayer:
> Hi kernel team.
>
> I was testing building the kernel for my radxa cm5+io shield, and it turns
> out there is no rtc in the DTS, so I got it from the radxa files.
> This is my first email to you, please help me correct it if something is
> off the standards.
>
> The commit attached does the trick. I used AI to assist me in this in
> case you're
> wondering.
Generally, please don't post patches as attachments.
For review comments it es expected to be able to comment
inline in the patch.
Ideally use git-send-email or b4 for sending patches.
For AI assisted changes, there is an Assisted-by: tag [0]
Please drop the Tested-by tag ... as you're sending in the patch and
your signed-off-by is on it, it is expected that you tested that change :-) .
Patch contents:
Please use names found in the schematics ... the pin is named
rtc_int_l there ... so the pinctrl entry should be "rtc_int_l: rtc-int-l { "...
This allows easier lookups when going from DT to schematics and back.
Thanks
Heiko
[0] https://docs.kernel.org/process/coding-assistants.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-03 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-02 19:09 [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board Brian Mayer
2026-07-03 16:12 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox