The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node page
Date: Thu, 9 Mar 2017 19:36:22 +0800	[thread overview]
Message-ID: <29a94fb3-67be-d326-b8f8-a553b18ee549@huawei.com> (raw)
In-Reply-To: <20170308213546.GB5483@jaegeuk.local>

On 2017/3/9 5:35, Jaegeuk Kim wrote:
> On 03/08, Chao Yu wrote:
>> On 2017/3/7 5:51, Jaegeuk Kim wrote:
>>> If f2fs_new_inode() is failed, the bad inode will invalidate 0'th node page
>>> during f2fs_evict_inode(), which doesn't need to do.
>>
>> Hmm...should not allow other using of inode->i_ino in following codes of
>> f2fs_evict_inode, right?
> 
> Right.

I mean those codes below invalidate_mapping_pages(NODE_MAPPING(sbi),,)
After having a look at them, I think it's OK without any change. :)

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

      reply	other threads:[~2017-03-09 11:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06 21:51 [PATCH 1/2] f2fs: don't need to invalidate wrong node page Jaegeuk Kim
2017-03-06 21:51 ` [PATCH 2/2] f2fs: don't overwrite node block by SSR Jaegeuk Kim
2017-03-08 12:30   ` [f2fs-dev] " Chao Yu
2017-03-08 21:39     ` Jaegeuk Kim
2017-03-09 12:07       ` Chao Yu
2017-03-08 12:17 ` [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node page Chao Yu
2017-03-08 21:35   ` Jaegeuk Kim
2017-03-09 11:36     ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29a94fb3-67be-d326-b8f8-a553b18ee549@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox