[PATCH] clk: bcm: bcm53573: fix OF node leak in init

[PATCH] clk: bcm: bcm53573: fix OF node leak in init

[Krzysztof Kozlowski]

Driver code is leaking OF node reference from of_get_parent() in
bcm53573_ilp_init().  Usage of of_get_parent() is not needed in the
first place, because the parent node will not be freed while we are
processing given node (triggered by CLK_OF_DECLARE()).  Thus fix the
leak by accessing parent directly, instead of of_get_parent().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/clk/bcm/clk-bcm53573-ilp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/bcm/clk-bcm53573-ilp.c b/drivers/clk/bcm/clk-bcm53573-ilp.c
index 84f2af736ee8..83ef41d618be 100644
--- a/drivers/clk/bcm/clk-bcm53573-ilp.c
+++ b/drivers/clk/bcm/clk-bcm53573-ilp.c
@@ -112,7 +112,7 @@ static void bcm53573_ilp_init(struct device_node *np)
 		goto err_free_ilp;
 	}
 
-	ilp->regmap = syscon_node_to_regmap(of_get_parent(np));
+	ilp->regmap = syscon_node_to_regmap(np->parent);
 	if (IS_ERR(ilp->regmap)) {
 		err = PTR_ERR(ilp->regmap);
 		goto err_free_ilp;
-- 
2.43.0

Re: [PATCH] clk: bcm: bcm53573: fix OF node leak in init

[Stephen Boyd]

Quoting Krzysztof Kozlowski (2024-08-25 23:58:01)
> Driver code is leaking OF node reference from of_get_parent() in
> bcm53573_ilp_init().  Usage of of_get_parent() is not needed in the
> first place, because the parent node will not be freed while we are
> processing given node (triggered by CLK_OF_DECLARE()).  Thus fix the
> leak by accessing parent directly, instead of of_get_parent().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Applied to clk-next