From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <shuah@kernel.org>, Kees Cook <kees@kernel.org>
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests: lib: remove strscpy test
Date: Thu, 25 Jul 2024 08:45:47 -0600 [thread overview]
Message-ID: <2bdd359e-037c-4b7c-84e6-db381a619dcd@linuxfoundation.org> (raw)
In-Reply-To: <20240725121212.808206-1-usama.anjum@collabora.com>
On 7/25/24 06:11, Muhammad Usama Anjum wrote:
> The strscpy test loads test_strscpy module for testing. But test_strscpy
> was converted to Kunit (see fixes). Hence remove strscpy.
>
> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit")
Remove fixes tag - this isn't a fix and we don't want this propagating
to stable releases without kunit test for this.
It appears fixes tag is being used too generously for things that
aren't fixes. Let's use it only when it is a real fix.
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
thanks,
-- Shuah
next prev parent reply other threads:[~2024-07-25 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 12:11 [PATCH v2] selftests: lib: remove strscpy test Muhammad Usama Anjum
2024-07-25 14:45 ` Shuah Khan [this message]
2024-07-30 22:37 ` Shuah Khan
2024-07-31 8:32 ` Muhammad Usama Anjum
2024-07-31 18:13 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bdd359e-037c-4b7c-84e6-db381a619dcd@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox