From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Shuah Khan <skhan@linuxfoundation.org>, Kees Cook <kees@kernel.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests: lib: remove strscpy test
Date: Wed, 31 Jul 2024 13:32:48 +0500 [thread overview]
Message-ID: <d26b317b-edda-4bb8-a022-912cd1f76b3a@collabora.com> (raw)
In-Reply-To: <9d5c0793-e90a-4549-92b1-41ad06b85de6@linuxfoundation.org>
On 7/31/24 3:37 AM, Shuah Khan wrote:
> On 7/25/24 06:11, Muhammad Usama Anjum wrote:
>> The strscpy test loads test_strscpy module for testing. But test_strscpy
>> was converted to Kunit (see fixes). Hence remove strscpy.
>>
>> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>> Changes since v1:
>> - Remove from Makefile and config file as well
>> ---
>
> As mentioned in other threads on this conversion to kunit and removal
> of kselfttest - NACK on this patch.
>
> Please don't send me any more of these conversion and removal patches.
This patch is removing a dead kselftest as its corresponding test module
was moved years ago (in 2022). This test has been failing since then. It
seems like misunderstanding that I'm removing something.
>
> thanks,
> -- Shuah
>
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2024-07-31 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 12:11 [PATCH v2] selftests: lib: remove strscpy test Muhammad Usama Anjum
2024-07-25 14:45 ` Shuah Khan
2024-07-30 22:37 ` Shuah Khan
2024-07-31 8:32 ` Muhammad Usama Anjum [this message]
2024-07-31 18:13 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26b317b-edda-4bb8-a022-912cd1f76b3a@collabora.com \
--to=usama.anjum@collabora.com \
--cc=kees@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox