[PATCH v1] firmware:Fix an NULL vs IS_ERR() bug in probe

[PATCH v1] firmware:Fix an NULL vs IS_ERR() bug in probe

[Wang Ming]

The devm_memremap() function returns error pointers.
It never returns NULL. Fix the check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/firmware/stratix10-svc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 2d6741261..cab11af28 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -756,7 +756,7 @@ svc_create_memory_pool(struct platform_device *pdev,
 	paddr = begin;
 	size = end - begin;
 	va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
-	if (!va) {
+	if (IS_ERR(va)) {
 		dev_err(dev, "fail to remap shared memory\n");
 		return ERR_PTR(-EINVAL);
 	}
-- 
2.25.1

Re: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in svc_create_memory_pool()

[Dan Carpenter]

On Wed, Jul 05, 2023 at 08:21:02PM +0200, Markus Elfring wrote:
> Please apply a more appropriate patch subject.
> 

Markus, a number of people have asked you to stop with this nonsense.

> 
> > The devm_memremap() function returns error pointers.
> > It never returns NULL. Fix the check.
> 
> Would the following wording be helpful?
> 
> 
>   Replace a null pointer check by an error pointer check after a call
>   of the function “devm_memremap” in this function implementation.

No.  The original was fine.  The original commit message is more clear
than your proposed commit message.

regards,
dan carpenter

Re: 回复: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in svc_create_memory_pool()

[Dan Carpenter]

On Thu, Jul 06, 2023 at 08:44:39AM +0000, 王明-软件底层技术部 wrote:
> Thank you Dan carpenter.
> This patch has been submitted for a long time, but I have not heard back from the maintainer, 
> and I am confused whether I need to send it again

You have to wait for at least two weeks before asking about a patch.

But the merge window is open now so everyone is busy.  Add another week
because of the merge window.

regards,
dan carpenter

Re: 回复: 回复: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in svc_create_memory_pool()

[Dinh Nguyen]

On 7/6/23 03:56, 王明-软件底层技术部 wrote:
> I see. Thank you
> 
> -----邮件原件-----
> 发件人: Dan Carpenter <dan.carpenter@linaro.org>
> 发送时间: 2023年7月6日 16:52
> 收件人: 王明-软件底层技术部 <machel@vivo.com>
> 抄送: Dinh Nguyen <dinguyen@kernel.org>; LKML <linux-kernel@vger.kernel.org>; opensource.kernel <opensource.kernel@vivo.com>
> 主题: Re: 回复: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in svc_create_memory_pool()
> 
> On Thu, Jul 06, 2023 at 08:44:39AM +0000, 王明-软件底层技术部 wrote:
>> Thank you Dan carpenter.
>> This patch has been submitted for a long time, but I have not heard
>> back from the maintainer, and I am confused whether I need to send it
>> again

Looks like you sent an original patch on July 1st, then you sent another 
patch on July 4th. In the future, please take Dan's advice on 2 weeks 
and if you do need to resend you can add a 'RESEND' to the subject line, 
or just reply with a ping to the original patch. I was on a short leave. 
I'll take your patch next week with the edits from Dan's comments.

Thanks,
Dinh

Re: 回复: 回复: 回复: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in svc_create_memory_pool()

[Dinh Nguyen]

On 7/14/23 04:46, 王明-软件底层技术部 wrote:
> Hi Dinh
> Excuse me, I don't know if your vacation is over. This is the patch I submitted before:
> https://lore.kernel.org/all/20230704082706.1721-1-machel@vivo.com/
> regards

There was a comment from Dan Carpenter about adding the Fixes tag. I was 
waiting the patch with that.

Dinh