From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, kernel-janitors@vger.kernel.org
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Coccinelle <cocci@systeme.lip6.fr>,
LKML <linux-kernel@vger.kernel.org>,
Ding Xiang <dingxiang@cmss.chinamobile.com>
Subject: Re: Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls
Date: Thu, 20 Jun 2019 21:34:52 +0200 [thread overview]
Message-ID: <2cae7d27-c032-20bf-4ecc-66a4a85a77cc@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1906202110310.3087@hadrien>
>> Would you prefer to clarify a more advanced approach?
>
> I think that something like
>
> if (IS_ERR(e))
> {
> <+...
> *dev_err(...)
> ...+>
> }
>
> would be more appropriate.
This SmPL construct can be more powerful.
> Whether there is a return or not doesn't really matter.
Such an adjustment can be helpful for a few operation modes.
But the number of statements in the if branch will influence the possibility
for the deletion of curly braces together with redundant dev_err() calls
by the SmPL patch mode.
>> Would you like to get the relevant function name dynamically determined?
>
> I have no idea what you consider "the relevant function name" to be.
> If it is always devm_ioremap_resource then it would seem that it does not
> need to be dynamically determined.
Do other functions share the same error reporting strategy so that any more
collateral software evolution can happen?
Regards,
Markus
next prev parent reply other threads:[~2019-06-20 19:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 17:30 [PATCH] Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls Markus Elfring
2019-06-20 18:48 ` Julia Lawall
2019-06-20 19:02 ` Markus Elfring
2019-06-20 19:02 ` Markus Elfring
2019-06-20 19:12 ` Julia Lawall
2019-06-20 19:34 ` Markus Elfring [this message]
2019-06-21 9:15 ` Markus Elfring
2019-06-21 9:21 ` Julia Lawall
2019-06-21 9:37 ` Markus Elfring
2019-06-21 9:37 ` Markus Elfring
2019-06-21 14:52 ` Julia Lawall
2019-07-01 8:10 ` [PATCH v2] " Markus Elfring
2019-07-01 10:48 ` Enrico Weigelt, metux IT consult
2019-07-01 12:40 ` [v2] Coccinelle: Suppression of warnings? Markus Elfring
2019-07-01 12:47 ` [PATCH v2] Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cae7d27-c032-20bf-4ecc-66a4a85a77cc@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=dingxiang@cmss.chinamobile.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox