public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>, Nuno Sa <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	 Olivier Moysan <olivier.moysan@foss.st.com>,
	Jyoti Bhayana <jbhayana@google.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Chris Down <chris@chrisdown.name>,
	John Ogness <john.ogness@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	linux-kernel@vger.kernel.org,  linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 2/4] iio: temperature: ltc2983: convert to dev_err_probe()
Date: Mon, 10 Jun 2024 09:11:28 +0200	[thread overview]
Message-ID: <2d7164356496ab910bdbcac471f91d874b9e075d.camel@gmail.com> (raw)
In-Reply-To: <20240608190600.622dfd7f@jic23-huawei>

On Sat, 2024-06-08 at 19:06 +0100, Jonathan Cameron wrote:
> On Thu, 6 Jun 2024 09:22:38 +0200
> Nuno Sa <nuno.sa@analog.com> wrote:
> 
> > Use dev_err_probe() (and variants) in the probe() path. While at it, made
> > some simple improvements:
> >  * Explicitly included the err.h and errno.h headers;
> >  * Removed some unnecessary line breaks;
> >  * Removed a redundant 'else';
> >  * Added some missing \n to prink.
> > 
> > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > ---
> 
> 
> > @@ -1296,8 +1268,8 @@ static int ltc2983_reg_access(struct iio_dev
> > *indio_dev,
> >  
> >  	if (readval)
> >  		return regmap_read(st->regmap, reg, readval);
> > -	else
> > -		return regmap_write(st->regmap, reg, writeval);
> > +
> > +	return regmap_write(st->regmap, reg, writeval);
> >  }
> 
> Unrelated.
> 
> Otherwise updates look correct to me.

Yeah, I know. It was simple enough that I sneaked it in and did mentioned it in
the commit message hoping it would make the change acceptable in here :)

- Nuno Sá

  reply	other threads:[~2024-06-10  7:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  7:22 [PATCH v3 0/4] dev_printk: add dev_errp_probe() helper Nuno Sa
2024-06-06  7:22 ` [PATCH v3 1/4] dev_printk: add new dev_err_probe() helpers Nuno Sa
2024-06-08 18:07   ` Jonathan Cameron
2024-06-17 19:41     ` Jonathan Cameron
2024-06-26 15:01       ` Nuno Sá
2024-06-30 11:29         ` Jonathan Cameron
2024-06-06  7:22 ` [PATCH v3 2/4] iio: temperature: ltc2983: convert to dev_err_probe() Nuno Sa
2024-06-06 10:17   ` Andy Shevchenko
2024-06-06 12:27     ` Nuno Sá
2024-06-06 14:12       ` Andy Shevchenko
2024-06-07 10:41         ` Nuno Sá
2024-06-08 18:06   ` Jonathan Cameron
2024-06-10  7:11     ` Nuno Sá [this message]
2024-06-11 17:11       ` Jonathan Cameron
2024-06-06  7:22 ` [PATCH v3 3/4] iio: backend: make use of dev_err_cast_probe() Nuno Sa
2024-06-06  7:22 ` [PATCH v3 4/4] iio: common: scmi_iio: convert to dev_err_probe() Nuno Sa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d7164356496ab910bdbcac471f91d874b9e075d.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=chris@chrisdown.name \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbhayana@google.com \
    --cc=jic23@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox