From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: Nuno Sa <nuno.sa@analog.com>, Petr Mladek <pmladek@suse.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Jyoti Bhayana <jbhayana@google.com>,
Chris Down <chris@chrisdown.name>,
John Ogness <john.ogness@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andi Shyti <andi.shyti@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 2/4] iio: temperature: ltc2983: convert to dev_err_probe()
Date: Thu, 6 Jun 2024 17:12:59 +0300 [thread overview]
Message-ID: <ZmHD63_tvC75To8r@smile.fi.intel.com> (raw)
In-Reply-To: <da57a64e4f5cdda7ee6b794c448995eee648c436.camel@gmail.com>
On Thu, Jun 06, 2024 at 02:27:03PM +0200, Nuno Sá wrote:
> On Thu, 2024-06-06 at 13:17 +0300, Andy Shevchenko wrote:
> > On Thu, Jun 06, 2024 at 09:22:38AM +0200, Nuno Sa wrote:
...
> > > + return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
> >
> > You can make all these lines shorter by using
> >
> > struct device *dev = &st->spi->dev; // or analogue
> >
> > at the top of the function.
> >
>
> Well, I had that in v2 (making the whole driver coherent with the local struct
> device helper but you kind of "complained" for a precursor patch (on a
> devm_kzalloc() call). So basically I deferred that change for a follow up patch.
Hmm... I don't remember the story behind this, but probably it's good to have
this done one (precursor) or the other way (follow up). Just check how many
changes will be done, whichever diff is shorter, choose that one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-06-06 14:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 7:22 [PATCH v3 0/4] dev_printk: add dev_errp_probe() helper Nuno Sa
2024-06-06 7:22 ` [PATCH v3 1/4] dev_printk: add new dev_err_probe() helpers Nuno Sa
2024-06-08 18:07 ` Jonathan Cameron
2024-06-17 19:41 ` Jonathan Cameron
2024-06-26 15:01 ` Nuno Sá
2024-06-30 11:29 ` Jonathan Cameron
2024-06-06 7:22 ` [PATCH v3 2/4] iio: temperature: ltc2983: convert to dev_err_probe() Nuno Sa
2024-06-06 10:17 ` Andy Shevchenko
2024-06-06 12:27 ` Nuno Sá
2024-06-06 14:12 ` Andy Shevchenko [this message]
2024-06-07 10:41 ` Nuno Sá
2024-06-08 18:06 ` Jonathan Cameron
2024-06-10 7:11 ` Nuno Sá
2024-06-11 17:11 ` Jonathan Cameron
2024-06-06 7:22 ` [PATCH v3 3/4] iio: backend: make use of dev_err_cast_probe() Nuno Sa
2024-06-06 7:22 ` [PATCH v3 4/4] iio: common: scmi_iio: convert to dev_err_probe() Nuno Sa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmHD63_tvC75To8r@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox