From: Dan Carpenter <dan.carpenter@linaro.org>
To: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/3] staging: media: max96712: fix typo
Date: Mon, 6 Jan 2025 11:28:55 +0300 [thread overview]
Message-ID: <2e9a2faa-29c2-413f-aaa9-c8f2dfced28f@stanley.mountain> (raw)
In-Reply-To: <20241219150644.64507-2-laurentiu.palcu@oss.nxp.com>
On Thu, Dec 19, 2024 at 05:06:41PM +0200, Laurentiu Palcu wrote:
> Fix a typo in VS_LOW expression.
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> ---
> drivers/staging/media/max96712/max96712.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> index 0751b2e048958..5228f9ec60859 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -182,7 +182,7 @@ static void max96712_pattern_enable(struct max96712_priv *priv, bool enable)
> max96712_write_bulk_value(priv, 0x1052, 0, 3);
> max96712_write_bulk_value(priv, 0x1055, v_sw * h_tot, 3);
> max96712_write_bulk_value(priv, 0x1058,
> - (v_active + v_fp + + v_bp) * h_tot, 3);
> + (v_active + v_fp + v_bp) * h_tot, 3);
Huh. I had expected this would be a bug in some way, but it actually
works fine. #MysteriesOfC
regards,
dan carpenter
next prev parent reply other threads:[~2025-01-06 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 15:06 [PATCH 0/3] staging: media: max96712: a few, mainly cosmetic, changes Laurentiu Palcu
2024-12-19 15:06 ` [PATCH 1/3] staging: media: max96712: fix typo Laurentiu Palcu
2024-12-19 17:06 ` Niklas Söderlund
2025-01-06 8:28 ` Dan Carpenter [this message]
2024-12-19 15:06 ` [PATCH 2/3] staging: media: max96712: enable extra debug register for max96724 Laurentiu Palcu
2024-12-19 17:09 ` Niklas Söderlund
2024-12-20 9:01 ` Laurentiu Palcu
2024-12-19 15:06 ` [PATCH 3/3] staging: media: max96712: add some register and field definitions Laurentiu Palcu
2024-12-19 17:10 ` Niklas Söderlund
2024-12-19 17:14 ` [PATCH 0/3] staging: media: max96712: a few, mainly cosmetic, changes Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9a2faa-29c2-413f-aaa9-c8f2dfced28f@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox