* [PATCH] clk: stm32f4: fix an uninitialized variable
@ 2025-01-24 11:16 Dario Binacchi
2025-03-04 19:50 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Dario Binacchi @ 2025-01-24 11:16 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Dan Carpenter, Alexandre Torgue, Maxime Coquelin,
Michael Turquette, Stephen Boyd, linux-arm-kernel, linux-clk,
linux-stm32
The variable s, used by pr_debug() to print the mnemonic of the modulation
depth in use, was not initialized. Fix the output by addressing the correct
mnemonic.
Fixes: 65b3516dbe50 ("clk: stm32f4: support spread spectrum clock generation")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
drivers/clk/clk-stm32f4.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
index f476883bc93b..85e23961ec34 100644
--- a/drivers/clk/clk-stm32f4.c
+++ b/drivers/clk/clk-stm32f4.c
@@ -888,7 +888,6 @@ static int __init stm32f4_pll_ssc_parse_dt(struct device_node *np,
struct stm32f4_pll_ssc *conf)
{
int ret;
- const char *s;
if (!conf)
return -EINVAL;
@@ -916,7 +915,8 @@ static int __init stm32f4_pll_ssc_parse_dt(struct device_node *np,
conf->mod_type = ret;
pr_debug("%pOF: SSCG settings: mod_freq: %d, mod_depth: %d mod_method: %s [%d]\n",
- np, conf->mod_freq, conf->mod_depth, s, conf->mod_type);
+ np, conf->mod_freq, conf->mod_depth,
+ stm32f4_ssc_mod_methods[ret], conf->mod_type);
return 0;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] clk: stm32f4: fix an uninitialized variable
2025-01-24 11:16 [PATCH] clk: stm32f4: fix an uninitialized variable Dario Binacchi
@ 2025-03-04 19:50 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2025-03-04 19:50 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: Dario Binacchi, Dan Carpenter, Alexandre Torgue, Maxime Coquelin,
Michael Turquette, linux-arm-kernel, linux-clk, linux-stm32
Quoting Dario Binacchi (2025-01-24 03:16:54)
> The variable s, used by pr_debug() to print the mnemonic of the modulation
> depth in use, was not initialized. Fix the output by addressing the correct
> mnemonic.
>
> Fixes: 65b3516dbe50 ("clk: stm32f4: support spread spectrum clock generation")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-04 19:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-24 11:16 [PATCH] clk: stm32f4: fix an uninitialized variable Dario Binacchi
2025-03-04 19:50 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox