From: Adrian Hunter <adrian.hunter@intel.com>
To: Jeremy Linton <jeremy.linton@arm.com>, linux-mmc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, ulf.hansson@linaro.org
Subject: Re: [PATCH] mmc: sdhci: Use more concise device_property_read_u64
Date: Wed, 25 Nov 2020 10:08:23 +0200 [thread overview]
Message-ID: <2f28f4c7-6f00-33ee-ac38-211c6fb07702@intel.com> (raw)
In-Reply-To: <20201125033630.603863-1-jeremy.linton@arm.com>
On 25/11/20 5:36 am, Jeremy Linton wrote:
> Since we only need a single u64 the _array form is
> unnecessarily. Use device_property_read_u64 instead.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Thank you :-)
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index feba64fbde16..ad4ae88a7f74 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3992,10 +3992,10 @@ void __sdhci_read_caps(struct sdhci_host *host, const u16 *ver,
> if (host->v4_mode)
> sdhci_do_enable_v4_mode(host);
>
> - device_property_read_u64_array(mmc_dev(host->mmc),
> - "sdhci-caps-mask", &dt_caps_mask, 1);
> - device_property_read_u64_array(mmc_dev(host->mmc),
> - "sdhci-caps", &dt_caps, 1);
> + device_property_read_u64(mmc_dev(host->mmc),
> + "sdhci-caps-mask", &dt_caps_mask);
> + device_property_read_u64(mmc_dev(host->mmc),
> + "sdhci-caps", &dt_caps);
>
> v = ver ? *ver : sdhci_readw(host, SDHCI_HOST_VERSION);
> host->version = (v & SDHCI_SPEC_VER_MASK) >> SDHCI_SPEC_VER_SHIFT;
>
next prev parent reply other threads:[~2020-11-25 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 3:36 [PATCH] mmc: sdhci: Use more concise device_property_read_u64 Jeremy Linton
2020-11-25 8:08 ` Adrian Hunter [this message]
2020-12-04 14:38 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f28f4c7-6f00-33ee-ac38-211c6fb07702@intel.com \
--to=adrian.hunter@intel.com \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox