* [PATCH] mmc: sdhci: Use more concise device_property_read_u64
@ 2020-11-25 3:36 Jeremy Linton
2020-11-25 8:08 ` Adrian Hunter
2020-12-04 14:38 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Jeremy Linton @ 2020-11-25 3:36 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-kernel, adrian.hunter, ulf.hansson, Jeremy Linton
Since we only need a single u64 the _array form is
unnecessarily. Use device_property_read_u64 instead.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
drivers/mmc/host/sdhci.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index feba64fbde16..ad4ae88a7f74 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -3992,10 +3992,10 @@ void __sdhci_read_caps(struct sdhci_host *host, const u16 *ver,
if (host->v4_mode)
sdhci_do_enable_v4_mode(host);
- device_property_read_u64_array(mmc_dev(host->mmc),
- "sdhci-caps-mask", &dt_caps_mask, 1);
- device_property_read_u64_array(mmc_dev(host->mmc),
- "sdhci-caps", &dt_caps, 1);
+ device_property_read_u64(mmc_dev(host->mmc),
+ "sdhci-caps-mask", &dt_caps_mask);
+ device_property_read_u64(mmc_dev(host->mmc),
+ "sdhci-caps", &dt_caps);
v = ver ? *ver : sdhci_readw(host, SDHCI_HOST_VERSION);
host->version = (v & SDHCI_SPEC_VER_MASK) >> SDHCI_SPEC_VER_SHIFT;
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci: Use more concise device_property_read_u64
2020-11-25 3:36 [PATCH] mmc: sdhci: Use more concise device_property_read_u64 Jeremy Linton
@ 2020-11-25 8:08 ` Adrian Hunter
2020-12-04 14:38 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2020-11-25 8:08 UTC (permalink / raw)
To: Jeremy Linton, linux-mmc; +Cc: linux-kernel, ulf.hansson
On 25/11/20 5:36 am, Jeremy Linton wrote:
> Since we only need a single u64 the _array form is
> unnecessarily. Use device_property_read_u64 instead.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Thank you :-)
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index feba64fbde16..ad4ae88a7f74 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3992,10 +3992,10 @@ void __sdhci_read_caps(struct sdhci_host *host, const u16 *ver,
> if (host->v4_mode)
> sdhci_do_enable_v4_mode(host);
>
> - device_property_read_u64_array(mmc_dev(host->mmc),
> - "sdhci-caps-mask", &dt_caps_mask, 1);
> - device_property_read_u64_array(mmc_dev(host->mmc),
> - "sdhci-caps", &dt_caps, 1);
> + device_property_read_u64(mmc_dev(host->mmc),
> + "sdhci-caps-mask", &dt_caps_mask);
> + device_property_read_u64(mmc_dev(host->mmc),
> + "sdhci-caps", &dt_caps);
>
> v = ver ? *ver : sdhci_readw(host, SDHCI_HOST_VERSION);
> host->version = (v & SDHCI_SPEC_VER_MASK) >> SDHCI_SPEC_VER_SHIFT;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci: Use more concise device_property_read_u64
2020-11-25 3:36 [PATCH] mmc: sdhci: Use more concise device_property_read_u64 Jeremy Linton
2020-11-25 8:08 ` Adrian Hunter
@ 2020-12-04 14:38 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-12-04 14:38 UTC (permalink / raw)
To: Jeremy Linton
Cc: linux-mmc@vger.kernel.org, Linux Kernel Mailing List,
Adrian Hunter
On Wed, 25 Nov 2020 at 04:36, Jeremy Linton <jeremy.linton@arm.com> wrote:
>
> Since we only need a single u64 the _array form is
> unnecessarily. Use device_property_read_u64 instead.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index feba64fbde16..ad4ae88a7f74 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3992,10 +3992,10 @@ void __sdhci_read_caps(struct sdhci_host *host, const u16 *ver,
> if (host->v4_mode)
> sdhci_do_enable_v4_mode(host);
>
> - device_property_read_u64_array(mmc_dev(host->mmc),
> - "sdhci-caps-mask", &dt_caps_mask, 1);
> - device_property_read_u64_array(mmc_dev(host->mmc),
> - "sdhci-caps", &dt_caps, 1);
> + device_property_read_u64(mmc_dev(host->mmc),
> + "sdhci-caps-mask", &dt_caps_mask);
> + device_property_read_u64(mmc_dev(host->mmc),
> + "sdhci-caps", &dt_caps);
>
> v = ver ? *ver : sdhci_readw(host, SDHCI_HOST_VERSION);
> host->version = (v & SDHCI_SPEC_VER_MASK) >> SDHCI_SPEC_VER_SHIFT;
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-04 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-25 3:36 [PATCH] mmc: sdhci: Use more concise device_property_read_u64 Jeremy Linton
2020-11-25 8:08 ` Adrian Hunter
2020-12-04 14:38 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox