Re: [PATCH RESEND v5 20/25] drm/msm/dpu: expose dpu_encoder ops for DP MST reuse

[Yongxing Mou <yongxing.mou@oss.qualcomm.com>]

On 7/13/2026 8:01 AM, Dmitry Baryshkov wrote:
> On Mon, Jun 29, 2026 at 10:14:41PM +0800, Yongxing Mou wrote:
>> Export dpu_encoder_atomic_mode_set, dpu_encoder_phys_enable and
>> dpu_encoder_phys_disable so MST encoder helper funcs can reuse them.
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>> ---
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 20 ++++++++++----------
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h |  6 ++++++
>>   2 files changed, 16 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>> index 778e231d4967..1c74ff6f0dbd 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>> @@ -1149,9 +1149,9 @@ void dpu_encoder_cleanup_wb_job(struct drm_encoder *drm_enc,
>>   	}
>>   }
>>   
>> -static void dpu_encoder_virt_atomic_mode_set(struct drm_encoder *drm_enc,
>> -					     struct drm_crtc_state *crtc_state,
>> -					     struct drm_connector_state *conn_state)
>> +void dpu_encoder_atomic_mode_set(struct drm_encoder *drm_enc,
>> +				 struct drm_crtc_state *crtc_state,
>> +				 struct drm_connector_state *conn_state)
> 
> The commit message says nothing about renaming the functions. Why are
> they being renamed?
> 
Got it.
>>   {
>>   	struct dpu_encoder_virt *dpu_enc;
>>   	struct msm_drm_private *priv;
>