* [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP
@ 2024-03-06 5:31 Gao Xiang
2024-03-06 6:51 ` Gao Xiang
0 siblings, 1 reply; 5+ messages in thread
From: Gao Xiang @ 2024-03-06 5:31 UTC (permalink / raw)
To: linux-erofs; +Cc: LKML, Gao Xiang
There are mainly two reasons that thp_get_unmapped_area() should be
used for EROFS as other filesystems:
- It's needed to enable PMD mappings as a FSDAX filesystem, see
commit 74d2fad1334d ("thp, dax: add thp_get_unmapped_area for pmd
mappings");
- It's useful together with CONFIG_READ_ONLY_THP_FOR_FS which enables
THPs for read-only mmapped files (e.g. shared libraries) even without
FSDAX. See commit 1854bc6e2420 ("mm/readahead: Align file mappings
for non-DAX").
Fixes: 06252e9ce05b ("erofs: dax support for non-tailpacking regular file")
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
fs/erofs/data.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index c98aeda8abb2..3d9721b3faa8 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -447,5 +447,6 @@ const struct file_operations erofs_file_fops = {
.llseek = generic_file_llseek,
.read_iter = erofs_file_read_iter,
.mmap = erofs_file_mmap,
+ .get_unmapped_area = thp_get_unmapped_area,
.splice_read = filemap_splice_read,
};
--
2.39.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP
2024-03-06 5:31 [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP Gao Xiang
@ 2024-03-06 6:51 ` Gao Xiang
2024-03-06 7:55 ` Jingbo Xu
2024-03-07 1:07 ` Chao Yu
0 siblings, 2 replies; 5+ messages in thread
From: Gao Xiang @ 2024-03-06 6:51 UTC (permalink / raw)
To: linux-erofs; +Cc: LKML
On 2024/3/6 13:31, Gao Xiang wrote:
> There are mainly two reasons that thp_get_unmapped_area() should be
> used for EROFS as other filesystems:
>
> - It's needed to enable PMD mappings as a FSDAX filesystem, see
> commit 74d2fad1334d ("thp, dax: add thp_get_unmapped_area for pmd
> mappings");
>
> - It's useful together with CONFIG_READ_ONLY_THP_FOR_FS which enables
> THPs for read-only mmapped files (e.g. shared libraries) even without
> FSDAX. See commit 1854bc6e2420 ("mm/readahead: Align file mappings
> for non-DAX").
Refine this part as
- It's useful together with large folios and CONFIG_READ_ONLY_THP_FOR_FS
which enable THPs for mmapped files (e.g. shared libraries) even without
...
>
> Fixes: 06252e9ce05b ("erofs: dax support for non-tailpacking regular file")
Fixes: ce529cc25b18 ("erofs: enable large folios for iomap mode")
Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> fs/erofs/data.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index c98aeda8abb2..3d9721b3faa8 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -447,5 +447,6 @@ const struct file_operations erofs_file_fops = {
> .llseek = generic_file_llseek,
> .read_iter = erofs_file_read_iter,
> .mmap = erofs_file_mmap,
> + .get_unmapped_area = thp_get_unmapped_area,
> .splice_read = filemap_splice_read,
> };
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP
2024-03-06 6:51 ` Gao Xiang
@ 2024-03-06 7:55 ` Jingbo Xu
2024-03-07 1:07 ` Chao Yu
1 sibling, 0 replies; 5+ messages in thread
From: Jingbo Xu @ 2024-03-06 7:55 UTC (permalink / raw)
To: Gao Xiang, linux-erofs; +Cc: LKML
On 3/6/24 2:51 PM, Gao Xiang wrote:
>
>
> On 2024/3/6 13:31, Gao Xiang wrote:
>> There are mainly two reasons that thp_get_unmapped_area() should be
>> used for EROFS as other filesystems:
>>
>> - It's needed to enable PMD mappings as a FSDAX filesystem, see
>> commit 74d2fad1334d ("thp, dax: add thp_get_unmapped_area for pmd
>> mappings");
>>
>> - It's useful together with CONFIG_READ_ONLY_THP_FOR_FS which enables
>> THPs for read-only mmapped files (e.g. shared libraries) even without
>> FSDAX. See commit 1854bc6e2420 ("mm/readahead: Align file mappings
>> for non-DAX").
>
> Refine this part as
>
> - It's useful together with large folios and CONFIG_READ_ONLY_THP_FOR_FS
> which enable THPs for mmapped files (e.g. shared libraries) even without
> ...
>
>>
>> Fixes: 06252e9ce05b ("erofs: dax support for non-tailpacking regular
>> file")
>
> Fixes: ce529cc25b18 ("erofs: enable large folios for iomap mode")
> Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
>
>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>> ---
>> fs/erofs/data.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
>> index c98aeda8abb2..3d9721b3faa8 100644
>> --- a/fs/erofs/data.c
>> +++ b/fs/erofs/data.c
>> @@ -447,5 +447,6 @@ const struct file_operations erofs_file_fops = {
>> .llseek = generic_file_llseek,
>> .read_iter = erofs_file_read_iter,
>> .mmap = erofs_file_mmap,
>> + .get_unmapped_area = thp_get_unmapped_area,
>> .splice_read = filemap_splice_read,
>> };
LGTM.
Reviewed-by: Jingbo Xu \<jefflexu@linux.alibaba.com>
--
Thanks,
Jingbo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP
2024-03-06 6:51 ` Gao Xiang
2024-03-06 7:55 ` Jingbo Xu
@ 2024-03-07 1:07 ` Chao Yu
2024-03-07 2:02 ` Gao Xiang
1 sibling, 1 reply; 5+ messages in thread
From: Chao Yu @ 2024-03-07 1:07 UTC (permalink / raw)
To: Gao Xiang, linux-erofs; +Cc: LKML
On 2024/3/6 14:51, Gao Xiang wrote:
>
>
> On 2024/3/6 13:31, Gao Xiang wrote:
>> There are mainly two reasons that thp_get_unmapped_area() should be
>> used for EROFS as other filesystems:
>>
>> - It's needed to enable PMD mappings as a FSDAX filesystem, see
>> commit 74d2fad1334d ("thp, dax: add thp_get_unmapped_area for pmd
>> mappings");
>>
>> - It's useful together with CONFIG_READ_ONLY_THP_FOR_FS which enables
>> THPs for read-only mmapped files (e.g. shared libraries) even without
>> FSDAX. See commit 1854bc6e2420 ("mm/readahead: Align file mappings
>> for non-DAX").
>
> Refine this part as
>
> - It's useful together with large folios and CONFIG_READ_ONLY_THP_FOR_FS
> which enable THPs for mmapped files (e.g. shared libraries) even without
> ...
>
>>
>> Fixes: 06252e9ce05b ("erofs: dax support for non-tailpacking regular file")
>
> Fixes: ce529cc25b18 ("erofs: enable large folios for iomap mode")
> Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
>
>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP
2024-03-07 1:07 ` Chao Yu
@ 2024-03-07 2:02 ` Gao Xiang
0 siblings, 0 replies; 5+ messages in thread
From: Gao Xiang @ 2024-03-07 2:02 UTC (permalink / raw)
To: Chao Yu, linux-erofs; +Cc: LKML
On 2024/3/7 09:07, Chao Yu wrote:
> On 2024/3/6 14:51, Gao Xiang wrote:
>>
>>
>> On 2024/3/6 13:31, Gao Xiang wrote:
>>> There are mainly two reasons that thp_get_unmapped_area() should be
>>> used for EROFS as other filesystems:
>>>
>>> - It's needed to enable PMD mappings as a FSDAX filesystem, see
>>> commit 74d2fad1334d ("thp, dax: add thp_get_unmapped_area for pmd
>>> mappings");
>>>
>>> - It's useful together with CONFIG_READ_ONLY_THP_FOR_FS which enables
>>> THPs for read-only mmapped files (e.g. shared libraries) even without
>>> FSDAX. See commit 1854bc6e2420 ("mm/readahead: Align file mappings
>>> for non-DAX").
>>
>> Refine this part as
>>
>> - It's useful together with large folios and CONFIG_READ_ONLY_THP_FOR_FS
>> which enable THPs for mmapped files (e.g. shared libraries) even without
>> ...
>>
>>>
>>> Fixes: 06252e9ce05b ("erofs: dax support for non-tailpacking regular file")
>>
>> Fixes: ce529cc25b18 ("erofs: enable large folios for iomap mode")
>> Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
>>
>>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>
> Reviewed-by: Chao Yu <chao@kernel.org>
Thanks, added!
Thanks,
Gao Xiang
>
> Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-07 2:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-06 5:31 [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP Gao Xiang
2024-03-06 6:51 ` Gao Xiang
2024-03-06 7:55 ` Jingbo Xu
2024-03-07 1:07 ` Chao Yu
2024-03-07 2:02 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox