public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Error during building on next-20250926 - kunit.py run --alltests run
@ 2025-09-28 21:11 Shuah Khan
  2025-09-28 21:22 ` Shuah Khan
  0 siblings, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2025-09-28 21:11 UTC (permalink / raw)
  To: Thomas Weißschuh, David Gow, johannes.berg
  Cc: Shuah Khan, shuah, Linux Kernel Mailing List,
	open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
	Networking

Hi Thomas and David,

I am seeing the following error during "kunit.py run --alltests run"
next-20250926.

$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=16
ERROR:root:/usr/bin/ld: drivers/net/wireless/intel/iwlwifi/tests/devinfo.o: in function `devinfo_pci_ids_config':
devinfo.c:(.text+0x2d): undefined reference to `iwl_bz_mac_cfg'
collect2: error: ld returned 1 exit status
make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1
make[2]: *** [/linux/linux_next/Makefile:1242: vmlinux] Error 2
make[1]: *** [/linux/linux_next/Makefile:248: __sub-make] Error 2
make: *** [Makefile:248: __sub-make] Error 2

Possile intearction between these two commits: Note: linux-kselftext
kunit branch is fine I am going send kunit pr to Linus later today.
Heads up that "kunit.py run --alltests run" is failing on next-20250926


commit 031cdd3bc3f369553933c1b0f4cb18000162c8ff
Author: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Date:   Mon Sep 8 09:03:38 2025 +0200

     kunit: Enable PCI on UML without triggering WARN()


commit 137b0bb916f1addb2ffbefd09a6e3e9d15fe6100
Author: Johannes Berg <johannes.berg@intel.com>
Date:   Mon Sep 15 11:34:28 2025 +0300

     wifi: iwlwifi: tests: check listed PCI IDs have configs

Note: linux-kselftext build just fine.

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Error during building on next-20250926 - kunit.py run --alltests run
  2025-09-28 21:11 Error during building on next-20250926 - kunit.py run --alltests run Shuah Khan
@ 2025-09-28 21:22 ` Shuah Khan
  2025-09-29  7:07   ` Berg, Johannes
  0 siblings, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2025-09-28 21:22 UTC (permalink / raw)
  To: Thomas Weißschuh, David Gow, johannes.berg
  Cc: shuah, Linux Kernel Mailing List,
	open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
	Networking, Shuah Khan

On 9/28/25 15:11, Shuah Khan wrote:
> Hi Thomas and David,
> 
> I am seeing the following error during "kunit.py run --alltests run"
> next-20250926.
> 
> $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=16
> ERROR:root:/usr/bin/ld: drivers/net/wireless/intel/iwlwifi/tests/devinfo.o: in function `devinfo_pci_ids_config':
> devinfo.c:(.text+0x2d): undefined reference to `iwl_bz_mac_cfg'
> collect2: error: ld returned 1 exit status
> make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1
> make[2]: *** [/linux/linux_next/Makefile:1242: vmlinux] Error 2
> make[1]: *** [/linux/linux_next/Makefile:248: __sub-make] Error 2
> make: *** [Makefile:248: __sub-make] Error 2

Same problem when running - kunit.py run --alltests --arch x86_64
> 
> Possile intearction between these two commits: Note: linux-kselftext
> kunit branch is fine I am going send kunit pr to Linus later today.
> Heads up that "kunit.py run --alltests run" is failing on next-20250926
> 
> 
> commit 031cdd3bc3f369553933c1b0f4cb18000162c8ff
> Author: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> Date:   Mon Sep 8 09:03:38 2025 +0200
> 
>      kunit: Enable PCI on UML without triggering WARN()
> 
> 
> commit 137b0bb916f1addb2ffbefd09a6e3e9d15fe6100
> Author: Johannes Berg <johannes.berg@intel.com>
> Date:   Mon Sep 15 11:34:28 2025 +0300
> 
>      wifi: iwlwifi: tests: check listed PCI IDs have configs
> 
> Note: linux-kselftext build just fine.

linux-kselftect kunit branch is fine.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: Error during building on next-20250926 - kunit.py run --alltests run
  2025-09-28 21:22 ` Shuah Khan
@ 2025-09-29  7:07   ` Berg, Johannes
  2025-09-29 16:05     ` Shuah Khan
  0 siblings, 1 reply; 5+ messages in thread
From: Berg, Johannes @ 2025-09-29  7:07 UTC (permalink / raw)
  To: Shuah Khan, Thomas Weißschuh, David Gow,
	Korenblit, Miriam Rachel
  Cc: shuah, Linux Kernel Mailing List,
	open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
	Networking

+Miri

Hi Shuah,

> > I am seeing the following error during "kunit.py run --alltests run"
> > next-20250926.
> >
> > $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit
> > --jobs=16
> > ERROR:root:/usr/bin/ld: drivers/net/wireless/intel/iwlwifi/tests/devinfo.o: in
> function `devinfo_pci_ids_config':
> > devinfo.c:(.text+0x2d): undefined reference to `iwl_bz_mac_cfg'
> > collect2: error: ld returned 1 exit status
> > make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped]
> > Error 1
> > make[2]: *** [/linux/linux_next/Makefile:1242: vmlinux] Error 2
> > make[1]: *** [/linux/linux_next/Makefile:248: __sub-make] Error 2
> > make: *** [Makefile:248: __sub-make] Error 2

Yeah, really my mistake, I didn't consider what happens in the test there when iwlwifi is built but without CONFIG_IWLMVM and CONFIG_IWLMLD.

I think we should add those to actually run their kunit tests too, which would fix the build issue, and maybe even CONFIG_IWLDVM to increase coverage of the tests in iwlwifi itself. I can send a patch for that.

All that said, the patch that breaks it is in linux-next via iwlwifi-next but seems to actually have missed the cutoff for 6.18, so we're good for now and I suppose Miri can even squash the build fix into that later.

johannes
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Error during building on next-20250926 - kunit.py run --alltests run
  2025-09-29  7:07   ` Berg, Johannes
@ 2025-09-29 16:05     ` Shuah Khan
  2025-09-29 16:07       ` Shuah Khan
  0 siblings, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2025-09-29 16:05 UTC (permalink / raw)
  To: Berg, Johannes, Thomas Weißschuh, David Gow,
	Korenblit, Miriam Rachel
  Cc: shuah, Linux Kernel Mailing List,
	open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
	Networking, Shuah Khan

On 9/29/25 01:07, Berg, Johannes wrote:
> +Miri
> 
> Hi Shuah,
> 
>>> I am seeing the following error during "kunit.py run --alltests run"
>>> next-20250926.
>>>
>>> $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit
>>> --jobs=16
>>> ERROR:root:/usr/bin/ld: drivers/net/wireless/intel/iwlwifi/tests/devinfo.o: in
>> function `devinfo_pci_ids_config':
>>> devinfo.c:(.text+0x2d): undefined reference to `iwl_bz_mac_cfg'
>>> collect2: error: ld returned 1 exit status
>>> make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped]
>>> Error 1
>>> make[2]: *** [/linux/linux_next/Makefile:1242: vmlinux] Error 2
>>> make[1]: *** [/linux/linux_next/Makefile:248: __sub-make] Error 2
>>> make: *** [Makefile:248: __sub-make] Error 2
> 
> Yeah, really my mistake, I didn't consider what happens in the test there when iwlwifi is built but without CONFIG_IWLMVM and CONFIG_IWLMLD.
> 
> I think we should add those to actually run their kunit tests too, which would fix the build issue, and maybe even CONFIG_IWLDVM to increase coverage of the tests in iwlwifi itself. I can send a patch for that.
> 
> All that said, the patch that breaks it is in linux-next via iwlwifi-next but seems to actually have missed the cutoff for 6.18, so we're good for now and I suppose Miri can even squash the build fix into that later.
> 

Thank you. Sounds like a plan.

I will send my kunit pr to Linus then.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Error during building on next-20250926 - kunit.py run --alltests run
  2025-09-29 16:05     ` Shuah Khan
@ 2025-09-29 16:07       ` Shuah Khan
  0 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2025-09-29 16:07 UTC (permalink / raw)
  To: Berg, Johannes, Thomas Weißschuh, David Gow,
	Korenblit, Miriam Rachel
  Cc: shuah, Linux Kernel Mailing List,
	open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
	Networking, Shuah Khan

On 9/29/25 10:05, Shuah Khan wrote:
> On 9/29/25 01:07, Berg, Johannes wrote:
>> +Miri
>>
>> Hi Shuah,
>>
>>>> I am seeing the following error during "kunit.py run --alltests run"
>>>> next-20250926.
>>>>
>>>> $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit
>>>> --jobs=16
>>>> ERROR:root:/usr/bin/ld: drivers/net/wireless/intel/iwlwifi/tests/devinfo.o: in
>>> function `devinfo_pci_ids_config':
>>>> devinfo.c:(.text+0x2d): undefined reference to `iwl_bz_mac_cfg'
>>>> collect2: error: ld returned 1 exit status
>>>> make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped]
>>>> Error 1
>>>> make[2]: *** [/linux/linux_next/Makefile:1242: vmlinux] Error 2
>>>> make[1]: *** [/linux/linux_next/Makefile:248: __sub-make] Error 2
>>>> make: *** [Makefile:248: __sub-make] Error 2
>>
>> Yeah, really my mistake, I didn't consider what happens in the test there when iwlwifi is built but without CONFIG_IWLMVM and CONFIG_IWLMLD.
>>
>> I think we should add those to actually run their kunit tests too, which would fix the build issue, and maybe even CONFIG_IWLDVM to increase coverage of the tests in iwlwifi itself. I can send a patch for that.
>>
>> All that said, the patch that breaks it is in linux-next via iwlwifi-next but seems to actually have missed the cutoff for 6.18, so we're good for now and I suppose Miri can even squash the build fix into that later.
>>
> 
> Thank you. Sounds like a plan.
> 
> I will send my kunit pr to Linus then.

Later on today - I mean.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-29 16:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-28 21:11 Error during building on next-20250926 - kunit.py run --alltests run Shuah Khan
2025-09-28 21:22 ` Shuah Khan
2025-09-29  7:07   ` Berg, Johannes
2025-09-29 16:05     ` Shuah Khan
2025-09-29 16:07       ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox