* Re: [PATCH] virt: tdx-guest: Fix the decrypted failure memory free
[not found] <20240613111931.43123-1-lirongqing@baidu.com>
@ 2024-06-13 16:07 ` Dave Hansen
2024-06-13 16:13 ` Edgecombe, Rick P
0 siblings, 1 reply; 2+ messages in thread
From: Dave Hansen @ 2024-06-13 16:07 UTC (permalink / raw)
To: Li RongQing, kirill.shutemov, dave.hansen, x86, linux-coco,
Edgecombe, Rick P, LKML
On 6/13/24 04:19, Li RongQing wrote:
> When set_memory_decrypted() fails, the memory should be encrypted
> via set_memory_encrypted(); if encrypting the memory fails, leak it
Please, always cc LKML on this stuff.
Second, Rick was looking in this area, but I'm not sure we ever applied
his patches. The idea was to never leak memory silently in these
failures. Doesn't this silently leak memory?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] virt: tdx-guest: Fix the decrypted failure memory free
2024-06-13 16:07 ` [PATCH] virt: tdx-guest: Fix the decrypted failure memory free Dave Hansen
@ 2024-06-13 16:13 ` Edgecombe, Rick P
0 siblings, 0 replies; 2+ messages in thread
From: Edgecombe, Rick P @ 2024-06-13 16:13 UTC (permalink / raw)
To: kirill.shutemov@linux.intel.com, linux-coco@lists.linux.dev,
Hansen, Dave, lirongqing@baidu.com, linux-kernel@vger.kernel.org,
dave.hansen@linux.intel.com, x86@kernel.org
On Thu, 2024-06-13 at 09:07 -0700, Dave Hansen wrote:
> Second, Rick was looking in this area, but I'm not sure we ever applied
> his patches. The idea was to never leak memory silently in these
> failures. Doesn't this silently leak memory?
They did get applied actually. After a fair amount of discussion the solution
was to always leak the pages, and rely on the WARN that happens in set_memory()
to make noise about it.
It looks like this instance popped up after the sweep through the code was done.
(at least in my local branch with the patches for the fixes, this code was not
merged yet)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-13 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240613111931.43123-1-lirongqing@baidu.com>
2024-06-13 16:07 ` [PATCH] virt: tdx-guest: Fix the decrypted failure memory free Dave Hansen
2024-06-13 16:13 ` Edgecombe, Rick P
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox