public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: bluetooth: Add qca6698 compatible string
@ 2024-10-30  9:47 Cheng Jiang
  2024-10-30 10:00 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Cheng Jiang @ 2024-10-30  9:47 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi,
	Rocky Liao
  Cc: linux-bluetooth, devicetree, linux-kernel, quic_chejiang

Add QCA6698 qcom,qca6698-bt compatible strings.

Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
---
Changes in v2:
- Add the compatibility for qcom,qca6698-bt

---
 .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index 7bb68311c609..f8eb5c09c1bf 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -18,6 +18,7 @@ properties:
     enum:
       - qcom,qca2066-bt
       - qcom,qca6174-bt
+      - qcom,qca6698-bt
       - qcom,qca9377-bt
       - qcom,wcn3988-bt
       - qcom,wcn3990-bt
@@ -169,6 +170,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,qca6698-bt
               - qcom,wcn6855-bt
     then:
       required:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: bluetooth: Add qca6698 compatible string
  2024-10-30  9:47 [PATCH v2] dt-bindings: bluetooth: Add qca6698 compatible string Cheng Jiang
@ 2024-10-30 10:00 ` Krzysztof Kozlowski
  2024-10-30 10:18   ` Cheng Jiang
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-30 10:00 UTC (permalink / raw)
  To: Cheng Jiang, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi,
	Rocky Liao
  Cc: linux-bluetooth, devicetree, linux-kernel

On 30/10/2024 10:47, Cheng Jiang wrote:
> Add QCA6698 qcom,qca6698-bt compatible strings.
> 
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
> Changes in v2:
> - Add the compatibility for qcom,qca6698-bt
> 
> ---
>  .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml   | 2 ++
>  1 file changed, 2 insertions(+)

Please wait with v2, v3 and so on.

Where is any user of this? Nothing in commit msg explains why this patch
is needed without users.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: bluetooth: Add qca6698 compatible string
  2024-10-30 10:00 ` Krzysztof Kozlowski
@ 2024-10-30 10:18   ` Cheng Jiang
  2024-10-30 10:20     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Cheng Jiang @ 2024-10-30 10:18 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Marcel Holtmann, Luiz Augusto von Dentz,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Balakrishna Godavarthi, Rocky Liao
  Cc: linux-bluetooth, devicetree, linux-kernel

Hi Krzysztof,

We have a new chip(qca6698) to attach on sa8775p-ride board. 


On 10/30/2024 6:00 PM, Krzysztof Kozlowski wrote:
> On 30/10/2024 10:47, Cheng Jiang wrote:
>> Add QCA6698 qcom,qca6698-bt compatible strings.
>>
>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
>> ---
>> Changes in v2:
>> - Add the compatibility for qcom,qca6698-bt
>>
>> ---
>>  .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml   | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Please wait with v2, v3 and so on.
> 
> Where is any user of this? Nothing in commit msg explains why this patch
> is needed without users.
> 
> Best regards,
> Krzysztof
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: bluetooth: Add qca6698 compatible string
  2024-10-30 10:18   ` Cheng Jiang
@ 2024-10-30 10:20     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-30 10:20 UTC (permalink / raw)
  To: Cheng Jiang, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi,
	Rocky Liao
  Cc: linux-bluetooth, devicetree, linux-kernel

On 30/10/2024 11:18, Cheng Jiang wrote:
> Hi Krzysztof,
> 
> We have a new chip(qca6698) to attach on sa8775p-ride board. 
> 
> 
> On 10/30/2024 6:00 PM, Krzysztof Kozlowski wrote:
>> On 30/10/2024 10:47, Cheng Jiang wrote:
>>> Add QCA6698 qcom,qca6698-bt compatible strings.
>>>
>>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
>>> ---
>>> Changes in v2:
>>> - Add the compatibility for qcom,qca6698-bt
>>>
>>> ---
>>>  .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml   | 2 ++
>>>  1 file changed, 2 insertions(+)
>>
>> Please wait with v2, v3 and so on.
>>
>> Where is any user of this? Nothing in commit msg explains why this patch
>> is needed without users.
>>

Don't top-post. If you have new chip, where is this binding used? I said
there are no users of it and you claim there is some, so where? Point me
to the patch and explain why it is not in this set.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-30 10:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-30  9:47 [PATCH v2] dt-bindings: bluetooth: Add qca6698 compatible string Cheng Jiang
2024-10-30 10:00 ` Krzysztof Kozlowski
2024-10-30 10:18   ` Cheng Jiang
2024-10-30 10:20     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox