From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Zhang Rui <rui.zhang@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH v2 02/11] thermal: core: Add and use a reverse thermal zone guard
Date: Fri, 11 Oct 2024 00:07:11 +0200 [thread overview]
Message-ID: <3344086.aeNJFYEL58@rjwysocki.net> (raw)
In-Reply-To: <4985597.31r3eYUQgx@rjwysocki.net>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Add a guard for unlocking a locked thermal zone temporarily and use it
in thermal_zone_pm_prepare().
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
This is a new patch
---
drivers/thermal/thermal_core.c | 8 +++-----
drivers/thermal/thermal_core.h | 3 +++
2 files changed, 6 insertions(+), 5 deletions(-)
Index: linux-pm/drivers/thermal/thermal_core.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_core.c
+++ linux-pm/drivers/thermal/thermal_core.c
@@ -1702,11 +1702,9 @@ static void thermal_zone_pm_prepare(stru
* acquired the lock yet, so release it to let the function run
* and wait util it has done the work.
*/
- mutex_unlock(&tz->lock);
-
- wait_for_completion(&tz->resume);
-
- mutex_lock(&tz->lock);
+ scoped_guard(thermal_zone_reverse, tz) {
+ wait_for_completion(&tz->resume);
+ }
}
tz->state |= TZ_STATE_FLAG_SUSPENDED;
Index: linux-pm/drivers/thermal/thermal_core.h
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_core.h
+++ linux-pm/drivers/thermal/thermal_core.h
@@ -148,6 +148,9 @@ struct thermal_zone_device {
DEFINE_GUARD(thermal_zone, struct thermal_zone_device *, mutex_lock(&_T->lock),
mutex_unlock(&_T->lock))
+DEFINE_GUARD(thermal_zone_reverse, struct thermal_zone_device *,
+ mutex_unlock(&_T->lock), mutex_lock(&_T->lock))
+
/* Initial thermal zone temperature. */
#define THERMAL_TEMP_INIT INT_MIN
next prev parent reply other threads:[~2024-10-10 22:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 21:59 [PATCH v2 00/11] thermal: core: Reimplement locking through guards Rafael J. Wysocki
2024-10-10 22:05 ` [PATCH v2 01/11] thermal: core: Add and use thermal zone guard Rafael J. Wysocki
2024-10-21 11:40 ` Markus Elfring
2024-10-21 11:49 ` Rafael J. Wysocki
2024-10-21 12:02 ` [v2 " Markus Elfring
2024-10-21 12:03 ` Rafael J. Wysocki
2024-10-22 21:02 ` [PATCH v2 " Lukasz Luba
2024-10-23 9:50 ` Rafael J. Wysocki
2024-10-25 13:53 ` Lukasz Luba
2024-10-10 22:07 ` Rafael J. Wysocki [this message]
2024-10-22 21:03 ` [PATCH v2 02/11] thermal: core: Add and use a reverse " Lukasz Luba
2024-10-10 22:09 ` [PATCH v2 03/11] thermal: core: Separate code running under thermal_list_lock Rafael J. Wysocki
2024-10-22 21:09 ` Lukasz Luba
2024-10-10 22:10 ` [PATCH v2 04/11] thermal: core: Manage thermal_list_lock using a mutex guard Rafael J. Wysocki
2024-10-22 22:50 ` Lukasz Luba
2024-10-10 22:12 ` [PATCH v2 05/11] thermal: core: Call thermal_governor_update_tz() outside of cdev lock Rafael J. Wysocki
2024-10-22 21:10 ` Lukasz Luba
2024-10-10 22:13 ` [PATCH v2 06/11] thermal: core: Introduce thermal_instance_add() Rafael J. Wysocki
2024-10-22 21:45 ` Lukasz Luba
2024-10-10 22:15 ` [PATCH v2 07/11] thermal: core: Introduce thermal_instance_delete() Rafael J. Wysocki
2024-10-22 21:48 ` Lukasz Luba
2024-10-10 22:16 ` [PATCH v2 08/11] thermal: core: Introduce thermal_cdev_update_nocheck() Rafael J. Wysocki
2024-10-22 22:23 ` Lukasz Luba
2024-10-10 22:19 ` [PATCH v2 09/11] thermal: core: Add and use cooling device guard Rafael J. Wysocki
2024-10-14 12:26 ` Rafael J. Wysocki
2024-10-22 22:25 ` Lukasz Luba
2024-10-23 8:52 ` Rafael J. Wysocki
2024-10-10 22:20 ` [PATCH v2 10/11] thermal: core: Separate thermal zone governor initialization Rafael J. Wysocki
2024-10-22 22:32 ` Lukasz Luba
2024-10-10 22:22 ` [PATCH v2 11/11] thermal: core: Manage thermal_governor_lock using a mutex guard Rafael J. Wysocki
2024-10-22 22:35 ` Lukasz Luba
2024-10-11 18:51 ` [PATCH v2 00/11] thermal: core: Reimplement locking through guards Rafael J. Wysocki
2024-10-21 11:08 ` Rafael J. Wysocki
2024-10-21 22:03 ` Lukasz Luba
2024-10-22 9:57 ` Rafael J. Wysocki
2024-10-22 10:21 ` Lukasz Luba
2024-10-22 15:29 ` Rafael J. Wysocki
2024-10-14 14:59 ` [PATCH v2.1 09/11] thermal: core: Add and use cooling device guard Rafael J. Wysocki
2024-10-24 8:13 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3344086.aeNJFYEL58@rjwysocki.net \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox