From: Markus Elfring <Markus.Elfring@web.de>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v2 01/11] thermal: core: Add and use thermal zone guard
Date: Mon, 21 Oct 2024 13:40:52 +0200 [thread overview]
Message-ID: <40ec7bb0-02ef-4af7-8934-9f960fa15355@web.de> (raw)
In-Reply-To: <1930069.tdWV9SEqCh@rjwysocki.net>
…
> +++ linux-pm/drivers/thermal/thermal_helpers.c
> @@ -60,13 +60,13 @@ bool thermal_trip_is_bound_to_cdev(struc
> {
> bool ret;
>
> - mutex_lock(&tz->lock);
> + guard(thermal_zone)(tz);
> +
> mutex_lock(&cdev->lock);
>
> ret = thermal_instance_present(tz, cdev, trip);
>
> mutex_unlock(&cdev->lock);
> - mutex_unlock(&tz->lock);
>
> return ret;
> }
…
Would you become interested to apply a statement
like “guard(mutex)(&cdev->lock);”?
Regards,
Markus
next prev parent reply other threads:[~2024-10-21 11:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 21:59 [PATCH v2 00/11] thermal: core: Reimplement locking through guards Rafael J. Wysocki
2024-10-10 22:05 ` [PATCH v2 01/11] thermal: core: Add and use thermal zone guard Rafael J. Wysocki
2024-10-21 11:40 ` Markus Elfring [this message]
2024-10-21 11:49 ` Rafael J. Wysocki
2024-10-21 12:02 ` [v2 " Markus Elfring
2024-10-21 12:03 ` Rafael J. Wysocki
2024-10-22 21:02 ` [PATCH v2 " Lukasz Luba
2024-10-23 9:50 ` Rafael J. Wysocki
2024-10-25 13:53 ` Lukasz Luba
2024-10-10 22:07 ` [PATCH v2 02/11] thermal: core: Add and use a reverse " Rafael J. Wysocki
2024-10-22 21:03 ` Lukasz Luba
2024-10-10 22:09 ` [PATCH v2 03/11] thermal: core: Separate code running under thermal_list_lock Rafael J. Wysocki
2024-10-22 21:09 ` Lukasz Luba
2024-10-10 22:10 ` [PATCH v2 04/11] thermal: core: Manage thermal_list_lock using a mutex guard Rafael J. Wysocki
2024-10-22 22:50 ` Lukasz Luba
2024-10-10 22:12 ` [PATCH v2 05/11] thermal: core: Call thermal_governor_update_tz() outside of cdev lock Rafael J. Wysocki
2024-10-22 21:10 ` Lukasz Luba
2024-10-10 22:13 ` [PATCH v2 06/11] thermal: core: Introduce thermal_instance_add() Rafael J. Wysocki
2024-10-22 21:45 ` Lukasz Luba
2024-10-10 22:15 ` [PATCH v2 07/11] thermal: core: Introduce thermal_instance_delete() Rafael J. Wysocki
2024-10-22 21:48 ` Lukasz Luba
2024-10-10 22:16 ` [PATCH v2 08/11] thermal: core: Introduce thermal_cdev_update_nocheck() Rafael J. Wysocki
2024-10-22 22:23 ` Lukasz Luba
2024-10-10 22:19 ` [PATCH v2 09/11] thermal: core: Add and use cooling device guard Rafael J. Wysocki
2024-10-14 12:26 ` Rafael J. Wysocki
2024-10-22 22:25 ` Lukasz Luba
2024-10-23 8:52 ` Rafael J. Wysocki
2024-10-10 22:20 ` [PATCH v2 10/11] thermal: core: Separate thermal zone governor initialization Rafael J. Wysocki
2024-10-22 22:32 ` Lukasz Luba
2024-10-10 22:22 ` [PATCH v2 11/11] thermal: core: Manage thermal_governor_lock using a mutex guard Rafael J. Wysocki
2024-10-22 22:35 ` Lukasz Luba
2024-10-11 18:51 ` [PATCH v2 00/11] thermal: core: Reimplement locking through guards Rafael J. Wysocki
2024-10-21 11:08 ` Rafael J. Wysocki
2024-10-21 22:03 ` Lukasz Luba
2024-10-22 9:57 ` Rafael J. Wysocki
2024-10-22 10:21 ` Lukasz Luba
2024-10-22 15:29 ` Rafael J. Wysocki
2024-10-14 14:59 ` [PATCH v2.1 09/11] thermal: core: Add and use cooling device guard Rafael J. Wysocki
2024-10-24 8:13 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40ec7bb0-02ef-4af7-8934-9f960fa15355@web.de \
--to=markus.elfring@web.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox