From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
ikepanhc@gmail.com,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Armin Wolf" <W_Armin@gmx.de>,
linux-doc@vger.kernel.org,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
ibm-acpi-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir
Date: Mon, 09 Jun 2025 21:21:45 -0400 [thread overview]
Message-ID: <33d3ea0d-161d-4297-9a99-9e7e129b31b1@app.fastmail.com> (raw)
In-Reply-To: <aEdBWymLN7aYqkeB@smile.fi.intel.com>
Thanks Andy,
On Mon, Jun 9, 2025, at 4:17 PM, Andy Shevchenko wrote:
> On Mon, Jun 09, 2025 at 08:27:24AM -0400, Mark Pearson wrote:
>> Create lenovo subdirectory for holding Lenovo specific drivers.
>
> ...
>
>> LENOVO WMI HOTKEY UTILITIES DRIVER
>> M: Jackie Dong <xy-jackie@139.com>
>> L: platform-driver-x86@vger.kernel.org
>> S: Maintained
>> -F: drivers/platform/x86/lenovo-wmi-hotkey-utilities.c
>> +F: drivers/platform/x86/lenovo/lenovo-wmi-hotkey-utilities.c
>
> Is this correct?
>
Jackie is on my team, he wrote this driver originally (with some help) for one of the thinkbook platforms.
If there are any changes he should review them as he has access to the HW, but I'll be helping too.
I think it's fine - let me know if otherwise.
Just as background: We can't use our Lenovo email addresses for kernel contributions. They're based on an awful Outlook server that is incapable of handling text only emails, and also won't play nice with any other tooling (including git send-email). Not ideal but it is what it is, and I gave up fighting with IT about it (there are some workarounds, but they're arguably worse).
> Otherwise LGTM.
>
Thanks for the review
Mark
next prev parent reply other threads:[~2025-06-10 1:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 12:27 [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir Mark Pearson
2025-06-09 12:27 ` [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling Mark Pearson
2025-06-09 20:19 ` Andy Shevchenko
2025-06-10 1:26 ` Mark Pearson
2025-06-10 7:35 ` Ilpo Järvinen
2025-06-10 12:28 ` Mark Pearson
2025-06-10 13:33 ` Andy Shevchenko
2025-06-09 20:17 ` [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir Andy Shevchenko
2025-06-10 1:21 ` Mark Pearson [this message]
2025-06-10 10:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33d3ea0d-161d-4297-9a99-9e7e129b31b1@app.fastmail.com \
--to=mpearson-lenovo@squebb.ca \
--cc=W_Armin@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ikepanhc@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox