public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
	corbet@lwn.net, ikepanhc@gmail.com, hmh@hmh.eng.br,
	W_Armin@gmx.de, linux-doc@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	ibm-acpi-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling
Date: Mon, 9 Jun 2025 23:19:23 +0300	[thread overview]
Message-ID: <aEdBy6m_6aQr8l41@smile.fi.intel.com> (raw)
In-Reply-To: <20250609122736.3373471-2-mpearson-lenovo@squebb.ca>

On Mon, Jun 09, 2025 at 08:27:25AM -0400, Mark Pearson wrote:
> Fix issues reported by kernel test robot.
>  - Require DMI for think-lmi.
>  - Check return from getting serial string
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506062319.F0IpDxF6-lkp@intel.com/

> 

No blank line in tag block.

> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>

>  - New patch added to series.

Shouldn't it be the first one in the series? It seems to me that this is the
fix of the original code as well.

...

> +++ b/drivers/platform/x86/lenovo/think-lmi.c

My understanding is that you need either Kconfig or changing C file.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-06-09 20:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 12:27 [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir Mark Pearson
2025-06-09 12:27 ` [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling Mark Pearson
2025-06-09 20:19   ` Andy Shevchenko [this message]
2025-06-10  1:26     ` Mark Pearson
2025-06-10  7:35   ` Ilpo Järvinen
2025-06-10 12:28     ` Mark Pearson
2025-06-10 13:33       ` Andy Shevchenko
2025-06-09 20:17 ` [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir Andy Shevchenko
2025-06-10  1:21   ` Mark Pearson
2025-06-10 10:01     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEdBy6m_6aQr8l41@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=W_Armin@gmx.de \
    --cc=corbet@lwn.net \
    --cc=hdegoede@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox