From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yangbo Lu <yangbo.lu@nxp.com>, Lee Jones <lee.jones@linaro.org>,
Dirk Behme <dirk.behme@de.bosch.com>,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] base: soc: Early register bus when needed
Date: Mon, 10 Oct 2016 16:15:05 +0200 [thread overview]
Message-ID: <3420819.lDRyD1Xpvb@wuerfel> (raw)
In-Reply-To: <1475572167-29581-2-git-send-email-geert+renesas@glider.be>
On Tuesday, October 4, 2016 11:09:24 AM CEST Geert Uytterhoeven wrote:
> If soc_device_register() is called before soc_bus_register(), it crashes
> with a NULL pointer dereference.
>
> soc_bus_register() is already a core_initcall(), but drivers/base/ is
> entered later than e.g. drivers/pinctrl/ and drivers/soc/. Hence there
> are several subsystems that may need to know SoC revision information,
> while it's not so easy to initialize the SoC bus even earlier using an
> initcall.
>
> To fix this, let soc_device_register() register the bus early if that
> hasn't happened yet.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
Not nice, but I can't think of a better alternative, so
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-10-10 14:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 9:09 [PATCH 0/4] soc: renesas: Identify SoC and register with the SoC bus Geert Uytterhoeven
2016-10-04 9:09 ` [PATCH 1/4] base: soc: Early register bus when needed Geert Uytterhoeven
2016-10-10 14:15 ` Arnd Bergmann [this message]
2016-10-04 9:09 ` [PATCH 2/4] base: soc: Introduce soc_device_match() interface Geert Uytterhoeven
2016-10-04 9:09 ` [PATCH 3/4] base: soc: Check for NULL SoC device attributes Geert Uytterhoeven
2016-10-10 14:13 ` Arnd Bergmann
2016-10-04 9:09 ` [PATCH/RFC 4/4] soc: renesas: Identify SoC and register with the SoC bus Geert Uytterhoeven
2016-10-05 12:17 ` Dirk Behme
2016-10-10 14:23 ` Arnd Bergmann
2016-10-19 8:02 ` Geert Uytterhoeven
2016-10-19 10:59 ` Arnd Bergmann
2016-10-21 18:16 ` Geert Uytterhoeven
2016-10-21 21:16 ` Arnd Bergmann
2016-10-22 7:44 ` Geert Uytterhoeven
2016-10-29 21:27 ` Arnd Bergmann
2016-10-31 10:30 ` Geert Uytterhoeven
2016-10-10 14:28 ` [PATCH 0/4] " Arnd Bergmann
2016-10-19 8:10 ` Geert Uytterhoeven
2016-10-19 10:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3420819.lDRyD1Xpvb@wuerfel \
--to=arnd@arndb.de \
--cc=dirk.behme@de.bosch.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox